Included Entity type in the routing map #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #455 +/- ##
============================================
- Coverage 67.53% 67.53% -0.01%
- Complexity 1582 1589 +7
============================================
Files 142 143 +1
Lines 6160 6172 +12
Branches 667 669 +2
============================================
+ Hits 4160 4168 +8
- Misses 1717 1719 +2
- Partials 283 285 +2 ☔ View full report in Codecov by Sentry. |
yihzhou
reviewed
Oct 21, 2024
dao-api/src/main/java/com/linkedin/metadata/dao/ingestion/AspectCallbackMapKey.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Every dao has the registry and lambda logic, and the aspect routing may only be needed for specific asset, so we can reduce the number of calls by filtering out using entity and aspect to check whether the routing client exists.
Testing Done
./gradlew build
Unit test
Checklist