Refactored RPC Routing for grpc implementation #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #447 +/- ##
============================================
+ Coverage 67.57% 67.59% +0.01%
- Complexity 1548 1572 +24
============================================
Files 138 142 +4
Lines 6082 6125 +43
Branches 659 660 +1
============================================
+ Hits 4110 4140 +30
- Misses 1693 1706 +13
Partials 279 279 ☔ View full report in Codecov by Sentry. |
JiaoMaWHU
reviewed
Oct 10, 2024
dao-api/src/main/java/com/linkedin/metadata/dao/ingestion/preupdate/PreUpdateResponse.java
Outdated
Show resolved
Hide resolved
dao-api/src/main/java/com/linkedin/metadata/dao/ingestion/preupdate/PreRoutingInfo.java
Outdated
Show resolved
Hide resolved
|
|
||
| public PreUpdateRoutingClient<? extends Message> preUpdateClient; | ||
|
|
||
| public enum RoutingAction { |
There was a problem hiding this comment.
do we still parse this action from annotation in models?
There was a problem hiding this comment.
That's something still in discussion.
...api/src/main/java/com/linkedin/metadata/dao/ingestion/preupdate/PreUpdateAspectRegistry.java
Outdated
Show resolved
Hide resolved
...api/src/main/java/com/linkedin/metadata/dao/ingestion/preupdate/PreUpdateAspectRegistry.java
Outdated
Show resolved
Hide resolved
dao-api/src/main/java/com/linkedin/metadata/dao/ingestion/preupdate/PreRoutingInfo.java
Outdated
Show resolved
Hide resolved
dao-api/src/main/java/com/linkedin/metadata/dao/BaseLocalDAO.java
Outdated
Show resolved
Hide resolved
restli-resources/src/main/java/com/linkedin/metadata/restli/BaseAspectRoutingResource.java
Outdated
Show resolved
Hide resolved
added 2 commits
October 11, 2024 08:37
JiaoMaWHU
reviewed
Oct 11, 2024
...api/src/main/java/com/linkedin/metadata/dao/ingestion/preupdate/PreUpdateAspectRegistry.java
Outdated
Show resolved
Hide resolved
...api/src/main/java/com/linkedin/metadata/dao/ingestion/preupdate/PreUpdateAspectRegistry.java
Outdated
Show resolved
Hide resolved
dao-api/src/main/java/com/linkedin/metadata/dao/ingestion/preupdate/PreUpdateRoutingClient.java
Outdated
Show resolved
Hide resolved
added 2 commits
October 11, 2024 12:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactored RPC Routing for grpc implementation. It's just a copy of this PR #443. Difference is rather than having 2 different interfaces, we can have one single interface used by both Restli and grpc.
Follow up work is to refactor the code in metadata-store for DatasetAccountableOwnership
Testing Done
./gradlew build
Checklist