Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dual-write): add new ingestSkipPreUpdates resource endpoints #430

Merged
merged 6 commits into from
Sep 19, 2024

Conversation

jsdonn
Copy link
Contributor

@jsdonn jsdonn commented Sep 17, 2024

Summary

Users who have received explicit permission to use this API may do so to follow the ingestion path where all pre-ingestion update lambdas are skipped. This is useful to prevent loops like ingest() -> lambda -> ingest() -> lambda -> so on. Instead, the path will be ingest() -> lambda -> ingestSkipPreIngestionUpdates().

Testing Done

added a unit test

Checklist

@jsdonn jsdonn changed the title feat(dual-write): add new ingestSkipPreIngestionUpdates resource endpoints feat(dual-write): add new ingestSkipPreUpdates resource endpoints Sep 18, 2024
Copy link
Contributor

@hongliu2024 hongliu2024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@jsdonn jsdonn merged commit 0d7727e into linkedin:master Sep 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants