Bug fix for DatasetAccountableOwnership ingestion #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 12, 2024 14:32
rakhiagr
changed the title
added 2 commits
September 12, 2024 14:45
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #424 +/- ##
============================================
- Coverage 67.53% 67.52% -0.01%
Complexity 1521 1521
============================================
Files 137 137
Lines 5957 5956 -1
Branches 645 645
============================================
- Hits 4023 4022 -1
Misses 1661 1661
Partials 273 273 ☔ View full report in Codecov by Sentry. |
JiaoMaWHU
reviewed
Sep 12, 2024
restli-resources/src/test/java/com/linkedin/metadata/restli/BaseAspectRoutingResourceTest.java
Outdated
Show resolved
Hide resolved
JiaoMaWHU
approved these changes
Sep 12, 2024
rakhiagr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moved the skip logic inside preUpdateLambda check. That is, only skip ingestion when it has a prelambda registered.
Workflow failed because of deprecated version of actions/upload-artifact: updated to v3: Ref: reactjs/react.dev#7148
Testing Done
mint build
added a unit test for this case
Checklist