Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove tracking context from ingestAsset API #408

Merged

Conversation

yangyangv2
Copy link
Contributor

Summary

Remove IngestionTrackingContext from ingestAsset API template.

Testing Done

Checklist

@yangyangv2 yangyangv2 force-pushed the yanyang/remove-tracking-context-from-ingestasset-api branch 2 times, most recently from 402ab80 to 314368a Compare August 29, 2024 14:58
@yangyangv2 yangyangv2 force-pushed the yanyang/remove-tracking-context-from-ingestasset-api branch from 314368a to 35e14ce Compare August 29, 2024 15:09
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.87%. Comparing base (62dda81) to head (35e14ce).

Files with missing lines Patch % Lines
...din/metadata/restli/BaseAspectRoutingResource.java 0.00% 2 Missing ⚠️
...m/linkedin/metadata/restli/BaseEntityResource.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #408      +/-   ##
============================================
- Coverage     67.90%   67.87%   -0.03%     
  Complexity     1508     1508              
============================================
  Files           137      137              
  Lines          5876     5880       +4     
  Branches        629      631       +2     
============================================
+ Hits           3990     3991       +1     
- Misses         1620     1622       +2     
- Partials        266      267       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JiaoMaWHU JiaoMaWHU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yangyangv2 yangyangv2 merged commit 5cbf8fc into master Aug 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants