Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spotless #3

Merged
merged 7 commits into from
Oct 6, 2020
Merged

Spotless #3

merged 7 commits into from
Oct 6, 2020

Conversation

jplaisted
Copy link
Contributor

@jplaisted jplaisted commented Sep 30, 2020 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@jplaisted jplaisted marked this pull request as ready for review October 1, 2020 00:53
Apply spotless to markdown and enforce via github flow.
43d2250 
imo a lot of the markdown was very hard to read (in markdown, rendered was fine / is the same). This spotless plugin helps to enforce a format.

Also remove old workflow files.
mars-lan
mars-lan suggested changes Oct 5, 2020
View reviewed changes
mars-lan
mars-lan reviewed Oct 5, 2020
View reviewed changes
@jplaisted jplaisted merged commit f25105a into master Oct 6, 2020
@jplaisted jplaisted deleted the spotless branch October 6, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mars-lan mars-lan mars-lan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jplaisted @mars-lan