Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: #353 convert raw html to markdown and viceversa #381

Merged
merged 5 commits into from
Nov 27, 2024
Merged

Feat: #353 convert raw html to markdown and viceversa #381

merged 5 commits into from
Nov 27, 2024

Conversation

FrancescoRepo
Copy link
Contributor

This PR contains the implementation of enhancement #353

  • New button "Convert to markdown" marked as an experimental feature, added in the Create Blog Page. The button, when pressed, transforms the content of the blog post from HTML to Markdown using the library suggested by the project owner and vice versa
  • Two new unit tests added for the implementation made

linkdotnet
linkdotnet reviewed Nov 26, 2024
View reviewed changes
Copy link
Owner

@linkdotnet linkdotnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - good start. I added some suggestion to align with the current codestyle and one suggestion where I (personally) would like to have the button.

src/LinkDotNet.Blog.Web/Features/Admin/BlogPostEditor/Components/CreateNewBlogPost.razor Outdated Show resolved Hide resolved
src/LinkDotNet.Blog.Web/Features/Admin/BlogPostEditor/Components/CreateNewBlogPost.razor Outdated Show resolved Hide resolved
src/LinkDotNet.Blog.Web/Features/Admin/BlogPostEditor/Components/CreateNewBlogPost.razor Outdated Show resolved Hide resolved
src/LinkDotNet.Blog.Web/Features/Admin/BlogPostEditor/Components/CreateNewBlogPost.razor Outdated Show resolved Hide resolved
src/LinkDotNet.Blog.Web/Features/Admin/BlogPostEditor/Components/CreateNewBlogPost.razor Outdated Show resolved Hide resolved
@linkdotnet
Copy link
Owner

Looking neat! Will check it out. Thanks again for the awesome initiative @FrancescoRepo

@linkdotnet
Copy link
Owner

From my side - I would merge the PR. Thanks again @FrancescoRepo

@linkdotnet
Copy link
Owner

Closes #353

@linkdotnet linkdotnet merged commit 391fd5d into linkdotnet:master Nov 27, 2024
1 check passed
@linkdotnet linkdotnet mentioned this pull request Nov 27, 2024
Closed
@FrancescoRepo FrancescoRepo deleted the feature/html_to_markdown branch November 29, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linkdotnet linkdotnet linkdotnet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FrancescoRepo @linkdotnet