Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win: drop support for windows 8 #4624

Merged
merged 1 commit into from
Nov 28, 2024
Merged

win: drop support for windows 8 #4624

merged 1 commit into from
Nov 28, 2024
+4 −4

Conversation

bnoordhuis
Copy link
Member

Fixes: #3889

There's probably more that can be simplified now. Suggestions?

@bnoordhuis
Copy link
Member Author

I don't get why GetFileInformationByName is undefined... is that not a thing on Windows Server 2019/2022?

@vtjnash
Copy link
Member

vtjnash commented Nov 27, 2024

GetFileInformationByName was added last year

@bnoordhuis
Copy link
Member Author

Okay, so not safe to assume it's there, even on win10?

@vtjnash
Copy link
Member

vtjnash commented Nov 27, 2024

Right, officially it isn't even part of Windows 11 yet (https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-getfileinformationbyname)

@huseyinacacak-janea
Copy link
Contributor

The GetFileInformationByName function was introduced to libuv as part of this PR. If I am not wrong, this API became available starting with Windows 11, version 24H2. Therefore, it’s not safe to assume that it will be present on all Windows 10 systems. Additionally, this API is available in Windows Server 2025 but not sure in Server 2019 and 2022.

@bnoordhuis
Copy link
Member Author

Okay, I dropped that change. Anything else that can be cut?

saghul
saghul approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a quick glance I don't see anything else.

@bnoordhuis bnoordhuis merged commit 1464408 into libuv:v1.x Nov 28, 2024
39 checks passed
@bnoordhuis bnoordhuis deleted the drop-win8 branch November 28, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saghul saghul saghul approved these changes

Assignees
No one assigned
Labels
windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop Windows 8.1 compatibility, on Jan 1, 2024
4 participants
@bnoordhuis @vtjnash @huseyinacacak-janea @saghul