Skip to content

doc: bump min supported linux and freebsd versions #3830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2022
Merged

doc: bump min supported linux and freebsd versions #3830

merged 1 commit into from
Nov 28, 2022

Conversation

bnoordhuis
Copy link
Member

The old Linux baseline was essentially RHEL 6 but that distro has been out of support for two years now. Move to RHEL 7.

This commit also moves FreeBSD to tier 2 because it isn't actually part of libuv's CI matrix, only Node's.

Fixes: #3822

@bnoordhuis bnoordhuis mentioned this pull request Nov 26, 2022
Closed
@bnoordhuis
doc: bump min supported linux and freebsd versions
6e8cc43 
The old Linux baseline was essentially RHEL 6 but that distro has been
out of support for two years now. Move to RHEL 7.

This commit also moves FreeBSD to tier 2 because it isn't actually
part of libuv's CI matrix, only Node's.

Fixes: libuv#3822
@bnoordhuis
Copy link
Member Author

I think this is good to go. Can I get a LGTM, por favor? :-)

santigimeno
santigimeno approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@santigimeno santigimeno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

por favor?

Por supuesto ;)

@bnoordhuis bnoordhuis merged commit 8ddffee into libuv:v1.x Nov 28, 2022
@bnoordhuis bnoordhuis deleted the fix3822 branch November 28, 2022 11:00
@johnsonjh johnsonjh mentioned this pull request Jan 4, 2023
Closed
@lewis6991
Copy link
Contributor

lewis6991 commented Feb 22, 2023 •
edited
Loading

This has broken builds for me on rhel 7.2 and 7.9 (both on 3.10) as sendmmsg is not defined. Can this be reverted?

@bnoordhuis
Copy link
Member Author

@lewis6991 it's probably an issue on your end, kernel+glibc on RHEL 7.9 are new enough. Possibly you have to update libc's devel headers.

@lewis6991
Copy link
Contributor

lewis6991 commented Feb 22, 2023 •
edited
Loading

Thanks for the pointer.

libc's devel headers.

I can't seem to find a package for this. Any idea what it'll be called? I've got glibc-devel and glibc-headers at 2.17 and kernel-headers.

One issue that might be causing this is that libuv seems to need gcc 4.9 (for stdatomic.h), whilst rhel7 only ships with 4.8.5. I got around this by using gcc via conda, but this could be causing the failures (though it did work before).

@bnoordhuis
Copy link
Member Author

2.17 is good, that's new enough. If you have a devtoolset-like setup, I suppose gcc may be looking in the wrong location. I don't have a concrete suggestion how to fix that, it's too long ago since I last used devtoolset. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau left review comments

@santigimeno santigimeno santigimeno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

linux: update kernel+glibc requirements?
4 participants
@bnoordhuis @lewis6991 @santigimeno @richardlau