Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darwin: bump minimum supported version to 10.15 #3406

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

bnoordhuis
Copy link
Member

We can't realistically claim to support 10.7 or any version that Apple
no longer supports so let's bump the baseline to something more
realistic.

Refs: #482
Refs: #3405

@richardlau
Copy link
Contributor

As a point of reference, for Node.js:

branch minimum supported macOS version
master 10.13 (but will likely be bumped soon ahead of Node.js 18.x nodejs/build#2815)
v17.x 10.13
v16.x 10.13
v14.x 10.11
v12.x 10.11

Node.js 12 and 14 are in maintenance -- I'd be okay to take the stance we'd stop updating libuv in those if any compatibility issues arise.

We also currently test on macOS 10.14 and 10.15 in the Jenkins CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit-osx-cmake/

@bnoordhuis
Copy link
Member Author

I believe Apple stopped supporting 10.14 last year, that's why I picked 10.15.

@mhdawson
Copy link
Contributor

mhdawson commented Jan 5, 2022

It would be a shame if Node.js 16.x could no longer take libuv updates.

@bnoordhuis
Copy link
Member Author

As long as it works, it works, right? I remember the LTS branches hardly ever took libuv updates so maybe it's academic anyway.

@saghul
Copy link
Member

saghul commented Jan 23, 2022

Generally speaking, Apple still does updates on "Latest - 1" versions. Maybe it could be phrased like such?

@bnoordhuis
Copy link
Member Author

@saghul Can you suggest alternate wording?

I do expect people to open issues asking for clarification if we're not explicit about version numbers because, well, people are people.

@saghul
Copy link
Member

saghul commented Feb 8, 2022

I'd put macOS >= 10.15 as the PR suggests, and then in the notes add something like: We generally support the latest macOS version and the previous one.

We can't realistically claim to support 10.7 or any version that Apple
no longer supports so let's bump the baseline to something more
realistic.

Refs: libuv#482
Refs: libuv#3405
@bnoordhuis
Copy link
Member Author

I shortened it to "Current and previous macOS release", otherwise the table starts looking unwieldy. PTAL!

@bnoordhuis bnoordhuis merged commit de24da8 into libuv:v1.x Feb 8, 2022
@bnoordhuis bnoordhuis deleted the bump-macos-baseline branch February 8, 2022 13:18
nodejs-github-bot pushed a commit to nodejs/node that referenced this pull request Mar 18, 2022
Update the macOS deployment target for Node.js 18 onwards.

PR-URL: #42292
Refs: nodejs/build#2815
Refs: libuv/libuv#3406
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
Update the macOS deployment target for Node.js 18 onwards.

PR-URL: nodejs#42292
Refs: nodejs/build#2815
Refs: libuv/libuv#3406
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
JeffroMF pushed a commit to JeffroMF/libuv that referenced this pull request May 16, 2022
We can't realistically claim to support 10.7 or any version that Apple
no longer supports so let's bump the baseline to something more
realistic.

Refs: libuv#482
Refs: libuv#3405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants