-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
darwin: bump minimum supported version to 10.15 #3406
Conversation
As a point of reference, for Node.js:
Node.js 12 and 14 are in maintenance -- I'd be okay to take the stance we'd stop updating libuv in those if any compatibility issues arise. We also currently test on macOS 10.14 and 10.15 in the Jenkins CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit-osx-cmake/ |
I believe Apple stopped supporting 10.14 last year, that's why I picked 10.15. |
It would be a shame if Node.js 16.x could no longer take libuv updates. |
As long as it works, it works, right? I remember the LTS branches hardly ever took libuv updates so maybe it's academic anyway. |
Generally speaking, Apple still does updates on "Latest - 1" versions. Maybe it could be phrased like such? |
@saghul Can you suggest alternate wording? I do expect people to open issues asking for clarification if we're not explicit about version numbers because, well, people are people. |
I'd put |
We can't realistically claim to support 10.7 or any version that Apple no longer supports so let's bump the baseline to something more realistic. Refs: libuv#482 Refs: libuv#3405
b3deaff
to
b56a846
Compare
I shortened it to "Current and previous macOS release", otherwise the table starts looking unwieldy. PTAL! |
Update the macOS deployment target for Node.js 18 onwards. PR-URL: #42292 Refs: nodejs/build#2815 Refs: libuv/libuv#3406 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Update the macOS deployment target for Node.js 18 onwards. PR-URL: nodejs#42292 Refs: nodejs/build#2815 Refs: libuv/libuv#3406 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
We can't realistically claim to support 10.7 or any version that Apple no longer supports so let's bump the baseline to something more realistic. Refs: libuv#482 Refs: libuv#3405
We can't realistically claim to support 10.7 or any version that Apple
no longer supports so let's bump the baseline to something more
realistic.
Refs: #482
Refs: #3405