fix: use undefined instead of null privKey (#154)

Respect the `PeerId#privKey` typescript type, which is `PrivateKey | undefined`, not `PrivateKey | null`
libp2p · Jul 26, 2021 · 35faac2 · 35faac2
1 parent 3330a26
commit 35faac2
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/index.js b/src/index.js
@@ -314,7 +314,7 @@ exports.createFromPubKey = async (key) => {
   }
 
   const pubKey = await cryptoKeys.unmarshalPublicKey(buf)
-  return computePeerId(null, pubKey)
+  return computePeerId(undefined, pubKey)
 }
 
 // Private key input will be a string
@@ -338,7 +338,7 @@ exports.createFromJSON = async (obj) => {
   const pub = rawPubKey && await cryptoKeys.unmarshalPublicKey(rawPubKey)
 
   if (!rawPrivKey) {
-    return new PeerIdWithIs(id, null, pub)
+    return new PeerIdWithIs(id, undefined, pub)
   }
 
   const privKey = await cryptoKeys.unmarshalPrivateKey(rawPrivKey)
@@ -394,7 +394,7 @@ exports.createFromProtobuf = async (buf) => {
   // TODO: val id and pubDigest
 
   if (pubKey) {
-    return new PeerIdWithIs(pubDigest, null, pubKey)
+    return new PeerIdWithIs(pubDigest, undefined, pubKey)
   }
 
   if (id) {