Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: improve GWT reflection lib over Method Modifiers. #7115 #7517

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Hugo801104
Copy link

The methods requested in the issue have been implemented

Copy link
Member

@tommyettinger tommyettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't help on GWT one bit! The reason GWT doesn't support this is that https://github.com/libgdx/libgdx/blob/master/backends/gdx-backends-gwt/src/com/badlogic/gwtref/client/Method.java doesn't support it, and that is used by https://github.com/libgdx/libgdx/blob/master/backends/gdx-backends-gwt/src/com/badlogic/gdx/backends/gwt/emu/com/badlogic/gdx/utils/reflect/Method.java , which is the actual Method implementation on GWT. The class you changed won't even be used by GWT, but if code tried to call any of the methods you added on GWT, it wouldn't compile because its Method version doesn't have that new code. I'll check and see if GWT even has existing code that can identify a synthetic or bridge method, though I doubt that. Those keywords might just do nothing on GWT, like strictfp.

@tommyettinger
Copy link
Member

Looks like synthetic isn't known to GWT normally, though it might be possible to add it during the non-GWT-based steps that generate the reflection cache. https://www.gwtproject.org/javadoc/latest/search.html?q=synthetic

Bridge doesn't fare any better. https://www.gwtproject.org/javadoc/latest/search.html?q=bridge It refers to a different concept in GWT.

@Hugo801104 Hugo801104 marked this pull request as draft December 17, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants