Get BSpline and a test for it working. #7515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-continuous splines were pretty severely broken, but so was the sloppy AI-generated code testing the whole class. The test code assumed that splines were essentially straight lines, and "curve == line" is obviously false to a human being. The code was useful as a basis, but the test cases were not, and caused test failures to appear incorrectly in some places. I'm not sure this works in all cases, but it passes more than it did before. I had to guess at what some of the intended behavior was without any meaningful docs, also. This closes libgdx#7513 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #7513 . It uses the code in that issue as a loose basis.
Non-continuous splines were pretty severely broken, but so was the sloppy AI-generated code testing the whole class. The test code assumed that splines were essentially straight lines, and "curve == line" is obviously false to a human being. The code was useful as a basis, but the test data was not, and caused test failures to appear incorrectly in some places.
I'm not sure this works in all cases, but it passes more than it did before. I had to guess at what some of the intended behavior was without any meaningful docs, also.