Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mitsubishi_ac not work(solved) #2230

Closed
tinho opened this issue Jan 10, 2019 · 1 comment
Closed

mitsubishi_ac not work(solved) #2230

tinho opened this issue Jan 10, 2019 · 1 comment
Labels
Status: Fixed Commit has been made, ready for testing Type: Bug Considered a bug

Comments

@tinho
Copy link

tinho commented Jan 10, 2019

in P035_IRTX.INO line 500 "SEND" is missing and not work cmd
change
#if MITSUBISHI_AC
case MITSUBISHI_AC:
to
#if SEND_MITSUBISHI_AC
case MITSUBISHI_AC:
thanks
TD-er added a commit that referenced this issue Jan 10, 2019
@TD-er
[IRTX] mitsubishi_ac not working #2230
bd3bfb7 
See #2230
@TD-er TD-er mentioned this issue Jan 10, 2019
Merged
@TD-er TD-er added the Status: Fixed Commit has been made, ready for testing label Jan 10, 2019
@TD-er
Copy link
Member

TD-er commented Jan 10, 2019

Thanks.
It will be merged as soon as I have other PR's ready to merge.

@TD-er TD-er added the Type: Bug Considered a bug label Jan 10, 2019
crankyoldgit added a commit to crankyoldgit/IRremoteESP8266 that referenced this issue Jan 11, 2019
@crankyoldgit
[BUG] Enum used instead of #define for Mitsubishi A/C.
bb566af 
Originally reported in letscontrolit/ESPEasy#2230

Fixes #596
@crankyoldgit crankyoldgit mentioned this issue Jan 11, 2019
Closed
crankyoldgit added a commit to crankyoldgit/IRremoteESP8266 that referenced this issue Jan 11, 2019
@crankyoldgit
[BUG] Fix incorrect #define usage.
24d3599 
Originally reported in letscontrolit/ESPEasy#2230

MITSUBISHI_AC -> SEND_MITSUBISHI_AC
SEND_MWM_ -> SEND_MWM

Fixes #596
@crankyoldgit crankyoldgit mentioned this issue Jan 11, 2019
Merged
crankyoldgit added a commit to crankyoldgit/IRremoteESP8266 that referenced this issue Jan 11, 2019
@crankyoldgit
[BUG] Fix incorrect #define usage. (#597)
c6d7bdb 
Originally reported in letscontrolit/ESPEasy#2230

MITSUBISHI_AC -> SEND_MITSUBISHI_AC
SEND_MWM_ -> SEND_MWM

Fixes #596
TD-er added a commit that referenced this issue Jan 20, 2019
@TD-er
Merge pull request #2231 from letscontrolit/bugfix/2230_IRTX_Mitsubishi
358b0d0 
[IRTX] mitsubishi_ac not working #2230
@TD-er TD-er closed this as completed Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Fixed Commit has been made, ready for testing Type: Bug Considered a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tinho @TD-er