put_file() persists request headers across multiple invocations #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows multiple calls to put_file to correctly calculate the request headers.
lericson
added a commit
that referenced
this pull request
Feb 28, 2012
put_file() persists request headers across multiple invocations
|
Thanks, man. |
|
Can we get a new simples3 release that incorporates this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simples3.streaming.StreamingMixin.put_file() is missing
without this, if you perform multiple put_file() calls, the second one will send an incorrect Content-Length value since the signature of put_file() uses a mutable dict as a default value to a keyword arg and is modified in the body.