This repository has been archived by the owner on Nov 7, 2023. It is now read-only.
Fix minor bugs with hair and SFX #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. SFX 9 should be played on triggering an invalid dash; 2. The last circle for the character's hair is not drawn.
|
Thanks for the contribution! Admittedly, the code isn't well formatted, so I completely missed that misleading elseif, and I took a very lazy approach to translating those foreach loops, which naturally ended up being error prone 😅. As for the other effects, the game uses 17 clouds and 25 particles, and I believe I'm making the same off-by-one error and processing only 16 and 24 respectively, looking at it now. I'll correct all of the |
|
Commit ffe6229 should ensure clouds and particles don't have the same issue. Thanks again for the pull request! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I am porting ccleste to other platforms with raylib, and have spotted issues with simple fixes. Details are as follows.
(1) SFX 9 should be played on triggering an invalid dash
This is caused by mistranslation of a block at line 279 of the original code.
The
elseifis not paired with theif(as there is already anend); it is for the outer one. This can be very misleading if tabstop is set to 2 🤣(2) The last circle for the character's hair is not drawn
The original game draws 5 circles, but ccleste draws only 4.
There are similar structures (looping with
while (!isLast)to emulateforeachin the original Lua code) for clouds and particles. This issue does not affect clouds, as only the 25th cloud in the stage will disappear, and there are not as many clouds in-game; but for particles I have not looked into more details. Maybe I will update the commit later.