Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Close voice typing session when closing the editor #11466

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Android: Close voice typing session when closing the editor #11466

wants to merge 2 commits into from

Conversation

personalizedrefrigerator
Copy link
Collaborator

Summary

This pull request closes the voice typing session when closing the editor. Previously, voice typing was only closed when clicking "Done".

Testing plan

This pull request has been manually tested with the following steps:

  1. Start voice typing in a note.
  2. Verify that the microphone indicator is shown.
    • On my device, a green dot is shown near the top right corner of the screen.
  3. Close the note by clicking the "back" button.
  4. Wait 2-3 seconds.
  5. Verify that the microphone indicator is no longer visible.
  6. Repeat steps 1-5.

This has been tested successfully on an Android 13 tablet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@personalizedrefrigerator