Langchain Community: Added OAuth Support to YoutubeLoader for restricted videos #28427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
community
bug
baskaryan
reviewed
Dec 9, 2024
| transcript_format: TranscriptFormat = TranscriptFormat.TEXT, | ||
| continue_on_failure: bool = False, | ||
| chunk_size_seconds: int = 120, | ||
| use_oauth: bool = True, |
Collaborator
There was a problem hiding this comment.
setting to True by default is a breaking change, lets set to False
Collaborator
|
Closing as author is unresponsive but happy to re-open if we want to keep iterating on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(This PR has contributions from @khushiDesai, @anushak18, and @ssumaiyaahmed).
This PR addresses Issue #27988 which addresses the bug where YoutubeLoader fails when attempting to load videos that require login credentials. The issue seemed to occur due to the lack of OAuth support in the pytube integration.
This pull request adds the following:
use_oauthandallow_oauth_cacheas optional arguments toYoutubeLoader.from_youtube_urlinyoutube.pyIssues
Issue #27988: Youtube requires login to view videoDetails
Testing
We added the following tests in
test_youtube.py:def test_from_youtube_urlchecks that thefrom_youtube_urlmethod correctly creates a YoutubeLoader and extracts the correct video information from various YouTube URL formats while also checks the OAuth settingsdef test_oauth_cachechecks that the OAuth caching works properly and prevents unnecessary login prompts when loading a video using the YoutubeLoader