Skip to content

Core: google docstring parsing fix #28404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 10, 2024
Merged

Core: google docstring parsing fix #28404

merged 2 commits into from
Dec 10, 2024

Conversation

Tesla2000
Copy link
Contributor

@Tesla2000 Tesla2000 commented Nov 28, 2024 •
edited
Loading

Thank you for contributing to LangChain!

  • PR title: "core: google docstring parsing fix"

  • PR message:

    • Description: Added a solution for invalid parsing of google docstring such as:
      Args:
      net_annual_income (float): The user's net annual income (in current year dollars).
    • Issue: Previous code would return arg = "net_annual_income (float)" which would cause exception in _validate_docstring_args_against_annotations
    • Dependencies: None

If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.

@vercel Vercel
Copy link

vercel bot commented Nov 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 0:27am

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. langchain Related to the langchain package 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Nov 28, 2024
@Tesla2000
Added a solution for invalid parsing of google docstring such as:
71afb43 
Args:
   net_annual_income (float): The user's net annual income (in current year dollars).
@efriis efriis self-assigned this Dec 10, 2024
efriis
efriis approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Dec 10, 2024
@efriis efriis enabled auto-merge (squash) December 10, 2024 00:11
@efriis efriis merged commit 4e743b5 into langchain-ai:master Dec 10, 2024
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efriis efriis efriis approved these changes

Assignees

@efriis efriis

Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature langchain Related to the langchain package lgtm PR looks good. Use to confirm that a PR is ready for merging. size:S This PR changes 10-29 lines, ignoring generated files.
Projects
PR Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tesla2000 @efriis