-
Notifications
You must be signed in to change notification settings - Fork 20.4k
fix: Set default search_type to 'similarity' in as_retriever method of AzureSearch #28376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding Vector Store SQL DB
Adding SQLServer Vector Store to the Index Table
…m90/langchain into sqlvector-langchain-branch
adding sqlserver vectore store matrix
…m90/langchain into sqlvector-langchain-branch
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
efriis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the search_type must be a string, and it defaults to "hybrid", so I don't think this PR makes sense
|
i.e. if you look at the default values in the |
|
Thank you for your comment, @efriis . The intent of this PR is to align with the comment and documentation for As you've correctly pointed out, the default value of |
Description
This PR updates the
as_retrievermethod in theAzureSearchto ensure that thesearch_typeparameter defaults to 'similarity' when not explicitly provided.Previously, if the
search_typewas omitted, it did not default to any specific value. So it was inherited fromAzureSearchVectorStoreRetriever, which defaults to 'hybrid'.This change ensures that the intended default behavior aligns with the expected usage.
Issue
No specific issue was found related to this change.
Dependencies
No new dependencies are introduced with this change.