Skip to content

rework replacer tests #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Nov 22, 2024
Merged

rework replacer tests #72

merged 34 commits into from
Nov 22, 2024

Conversation

pirog
Copy link
Member

@pirog pirog commented Nov 21, 2024

Bare minimum self-checks

What do you think of a person who only does the bare minimum?

  • I've updated this PR with the latest code from main
  • I've done a cursory QA pass of my code locally
  • I've ensured all automated status check and tests pass
  • I've connected this PR to an issue

Pieces of flare

  • I've written a unit or functional test for my code
  • I've updated relevant documentation it my code changes it
  • I've updated this repo's README if my code changes it
  • I've updated this repo's CHANGELOG with my change unless its a trivial change (like updating a typo in the docs)

Finally

If you have any issues or need help please join the #contributors channel in the Lando slack and someone will gladly help you out!

You can also check out the coder guide.

Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for get-lando canceled.

Name Link
🔨 Latest commit 59724b5
🔍 Latest deploy log https://app.netlify.com/sites/get-lando/deploys/6740aa7b85cdf100088a4253

Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for setup-lando ready!

Name Link
🔨 Latest commit 59724b5
🔍 Latest deploy log https://app.netlify.com/sites/setup-lando/deploys/6740aa7b60986d0008944fca
😎 Deploy Preview https://deploy-preview-72--setup-lando.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 59 (🔴 down 1 from production)
Accessibility: 98 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

pirog added 27 commits November 21, 2024 09:55
@pirog pirog marked this pull request as ready for review November 22, 2024 16:37
@pirog pirog merged commit b80d322 into main Nov 22, 2024
121 checks passed
@pirog pirog deleted the better-cleanup branch November 22, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant