#2: first pass on support for lando setup part 2

lando · Nov 6, 2023 · 68d3a04 · 68d3a04
1 parent a10b862
commit 68d3a04
Show file tree

Hide file tree

Showing 9 changed files with 9 additions and 12 deletions.
diff --git a/.github/workflows/pr-config-tests.yml b/.github/workflows/pr-config-tests.yml
@@ -19,7 +19,7 @@ jobs:
           - true
           - false
         node-version:
-          - '16'
+          - '18'
 
     steps:
       - name: Checkout code

diff --git a/.github/workflows/pr-dep-tests.yml b/.github/workflows/pr-dep-tests.yml
@@ -14,7 +14,7 @@ jobs:
         os:
           - ubuntu-22.04
         node-version:
-          - '16'
+          - '18'
         dependency-check:
           - error
           - warn

diff --git a/.github/workflows/pr-file-tests.yml b/.github/workflows/pr-file-tests.yml
@@ -14,7 +14,7 @@ jobs:
         os:
           - ubuntu-22.04
         node-version:
-          - '16'
+          - '18'
         lando-version-file:
           - '.lando-version'
           - '.tool-versions'

diff --git a/.github/workflows/pr-linter.yml b/.github/workflows/pr-linter.yml
@@ -11,7 +11,7 @@ jobs:
         os:
           - ubuntu-22.04
         node-version:
-          - '16'
+          - '18'
     steps:
       # Install deps and cache
       - name: Checkout code

diff --git a/.github/workflows/pr-os-tests.yml b/.github/workflows/pr-os-tests.yml
@@ -16,7 +16,7 @@ jobs:
           - ubuntu-22.04
           - windows-2022
         node-version:
-          - '16'
+          - '18'
 
     steps:
       - name: Checkout code

diff --git a/.github/workflows/pr-setup.yml b/.github/workflows/pr-setup.yml
@@ -16,7 +16,7 @@ jobs:
           - ubuntu-22.04
           # - windows-2022
         node-version:
-          - '16'
+          - '18'
 
     steps:
       - name: Checkout code

diff --git a/.github/workflows/pr-versions-tests.yml b/.github/workflows/pr-versions-tests.yml
@@ -14,7 +14,7 @@ jobs:
         os:
           - ubuntu-22.04
         node-version:
-          - '16'
+          - '18'
         lando-version:
           - '3.x'
           - '>2'

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -16,7 +16,7 @@ jobs:
         os:
           - ubuntu-22.04
         node-version:
-          - '16'
+          - '18'
 
     steps:
       - name: Checkout code

diff --git a/setup-lando.js b/setup-lando.js
@@ -37,9 +37,6 @@ const main = async () => {
   // start by getting the inputs and stuff
   const inputs = getInputs();
 
-  inputs.landoVersion = '3-dev';
-  inputs.setup = 'auto';
-
   // show a warning if both version inputs are set
   if (inputs.landoVersion && inputs.landoVersionFile) {
     core.warning('Both lando-version and lando-version-file inputs are specified, only lando-version will be used');
@@ -49,7 +46,7 @@ const main = async () => {
   // @NOTE: we use core.exportVariable because we want any GHA workflow that uses @lando/setup-lando to not need
   // to handle their own downstream lando debugging. Of course they can if they want since they migth want something
   // more targeted or wide than LANDO_DEBUG=1 eg LANDO_DEBUG="*" or LANDO_DEBUG="lando/core*"
-  // if (core.isDebug() || inputs.debug) core.exportVariable('LANDO_DEBUG', 1);
+  if (core.isDebug() || inputs.debug) core.exportVariable('LANDO_DEBUG', 1);
 
   // determine lando version spec to install
   const spec = inputs.landoVersion || getFileVersion(inputs.landoVersionFile) || 'stable';
-Original file line number
+Diff line change
@@ Expand Up / @@ -19,7 +19,7 @@ jobs: @@
               - true
               - false
             node-version:
-              - '16'
+              - '18'
         steps:
           - name: Checkout code
@@ Expand Down @@