Add template shape matching criteria #5914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
mateuszradomski
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves L2B-8058
A new file can be added to template's
shape/folder calledcriteria.json. The only supported key isvalidAddresses.When
criteria.jsonis present, the template must match not only an implementation, but also the criteria. If mutliple templates match, the more specific match wins (like in CSS selectors).This solves the issue with SuperchainConfig where we have one template for the correct one (deployed under canonical address) and a different template for "fake" deployments, where implementation is exactly the same, but address is different.
Side note: refresh-discovery and related test were significantly enhanced and a few previously unknown bugs fixed.