Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: describe nfd-topology-gc in introduction.md #1062

Merged
merged 1 commit into from
Feb 21, 2023
Merged

docs: describe nfd-topology-gc in introduction.md #1062

merged 1 commit into from
Feb 21, 2023

Conversation

yanggangtony
Copy link
Member

fix omit describe for nfd-topology-gc.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 17, 2023
@netlify
Copy link

netlify bot commented Feb 17, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 150d4f4
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/63effbe6cd2cdc0008c89f7a
😎 Deploy Preview https://deploy-preview-1062--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot
Copy link
Contributor

Welcome @yanggangtony!

It looks like this is your first PR to kubernetes-sigs/node-feature-discovery 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-feature-discovery has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @yanggangtony. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 17, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 17, 2023
marquiz
marquiz reviewed Feb 17, 2023
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yanggangtony for the contribution

Could you add a docs: "topic" to the git commit message title, e.g.

docs: describe nfd-topology-gc in introduction.md

or smth...

docs/get-started/introduction.md
@@ -24,6 +24,8 @@ NFD consists of three software components:
1. nfd-master
1. nfd-worker
1. nfd-topology-updater
1. nfd-topology-gc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also adjust the NFD consists of three software components: text above

Also, add a new sub-section for "NFD-Topology-GC". Just a one sentence description is enough for now

@marquiz
Copy link
Contributor

marquiz commented Feb 17, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 17, 2023
@yanggangtony
Copy link
Member Author

@marquiz
Thanks for review.
Rebased it.

marquiz
marquiz approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yanggangtony for the update. Looks good to me

I didn't realize that we already had a sub-section about topology-gc as it was named NFD-Topology-Garbage-Collector 🙈

/retitle docs: describe nfd-topology-gc in introduction.md

@k8s-ci-robot k8s-ci-robot changed the title fix omit describe for nfd-topology-gc docs: describe nfd-topology-gc in introduction.md Feb 20, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz, yanggangtony

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2023
ffromani
ffromani reviewed Feb 21, 2023
View reviewed changes
Copy link
Contributor

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2be00116c7c1c286941caf59fc6eca95c980e728

@k8s-ci-robot k8s-ci-robot merged commit 69440d7 into kubernetes-sigs:master Feb 21, 2023
@marquiz marquiz mentioned this pull request Apr 12, 2023
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffromani ffromani ffromani left review comments

@marquiz marquiz marquiz approved these changes

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

@fmuyassarov fmuyassarov Awaiting requested review from fmuyassarov

Assignees

@ffromani ffromani

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yanggangtony @k8s-ci-robot @marquiz @ffromani