Refactors the kstatus functions and adds unstructured support in the version check #117
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @somtochiama. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
k8s-ci-robot
added
the
size/L
| if !reflect.DeepEqual(status, s) { | ||
|
|
||
| unstructStatus = s | ||
| unstructStatus["Healthy"] = statusHealthy |
There was a problem hiding this comment.
Is it healthy or Healthy? It should be the JSON form I believe
| } else { | ||
| unstructStatus["Healthy"] = true | ||
| unstructStatus["Errors"] = statusErrors | ||
| } else if ok { |
There was a problem hiding this comment.
Idea for a future PR: I wonder if we can refactor this into our helper methods ... e.g. GetCommonStatus and SetCommonStatus
| } | ||
|
|
||
| unstructStatus = s | ||
| unstructStatus["Healthy"] = false |
There was a problem hiding this comment.
I think this one should be healthy (and errors) also
|
I think we can refactor the status get / set code into some helper functions, but this lgtm. /ok-to-test |
k8s-ci-robot
added
ok-to-test
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, SomtochiAma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
No description provided.