Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checks for ignore reconciliation annotations #105

Closed
wants to merge 4 commits into from
Closed

Checks for ignore reconciliation annotations #105

wants to merge 4 commits into from

Conversation

somtochiama
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 13, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @somtochiama. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SomtochiAma
To complete the pull request process, please assign johnsonj
You can assign the PR to them by writing /assign @johnsonj in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 13, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 17, 2020
justinsb
justinsb reviewed Jul 27, 2020
View reviewed changes
pkg/patterns/declarative/reconciler.go Outdated
@@ -103,6 +103,14 @@ func (r *Reconciler) Reconcile(request reconcile.Request) (reconcile.Result, err
}
}

annotations := instance.GetAnnotations()
if ignoreAnnotation, ok := annotations["addons.operators.ignore"]; ok {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can figure out a name for this in pairing :-)

pkg/patterns/declarative/reconciler.go Outdated
@@ -103,6 +103,14 @@ func (r *Reconciler) Reconcile(request reconcile.Request) (reconcile.Result, err
}
}

annotations := instance.GetAnnotations()
if ignoreAnnotation, ok := annotations["addons.operators.ignore"]; ok {
if ignoreAnnotation == "true" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just allow any value (or even no value), so if ok. (We might also want to rename ok to found)

pkg/patterns/declarative/pkg/manifest/objects.go Outdated
@@ -339,6 +339,14 @@ func ParseObjects(ctx context.Context, manifest string) (*Objects, error) {
// We don't reuse the manifest because it's probably yaml, and we want to use json
// json = yaml
o, err := NewObject(out)
annotations := o.object.GetAnnotations()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to support this on the manifest ... but if you can think of a reason we should allow it, that's fine.

@justinsb
Copy link
Contributor

We discussed in pairing; we agreed we should look for the annotation on the objects in the cluster, by reading them before applying. (And that same logic is useful in the health check, I believe)

@atoato88
Copy link
Contributor

This PR relates to #111 ?
If so, this PR is replaced with it and will close w/o merge?

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 31, 2020
@somtochiama
Copy link
Member Author

This PR relates to #111 ?
If so, this PR is replaced with it and will close w/o merge?

This PR could still be important. It checks for the ignore annotation on the Custom resource

@somtochiama
Copy link
Member Author

@justinsb should I close this?

@atoato88
Copy link
Contributor

@somtochiama
Sorry for late response.

It checks for the ignore annotation on the Custom resource

Yes, I think so too, current code of PR is LGTM.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2020
@somtochiama somtochiama mentioned this pull request Aug 14, 2020
Closed
6 tasks
@justinsb
Copy link
Contributor

justinsb commented Oct 8, 2020

@somtochiama and I discussed this; this might be useful in future so we don't just want to close it, but we instead implemented first an annotation on the manifest itself.

/ok-to-test

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 8, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2021
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 5, 2021
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb justinsb left review comments

@atoato88 atoato88 Awaiting requested review from atoato88

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

Assignees

@atoato88 atoato88

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@somtochiama @k8s-ci-robot @justinsb @atoato88 @fejta-bot