Generic controller #75

somtochiama · 2020-07-23T16:17:06Z

No description provided.

k8s-ci-robot · 2020-07-23T16:17:14Z

Hi @somtochiama. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dholbach · 2020-07-24T07:07:22Z

/ok-to-test
/uncc
/cc @stealthybox

justinsb · 2020-07-30T11:29:40Z

generic/main.go

+func init() {
+	_ = clientgoscheme.AddToScheme(scheme)
+
+	_ = addonsv1alpha1.AddToScheme(scheme) // <--------


Nit: We can remove the <--- marker :-)

justinsb · 2020-07-30T11:30:31Z

generic/main.go

+		os.Exit(1)
+	}
+
+	for i := range genericList.Items {


Nit: I think we should have a TODO to say "add a watch on Generic, respond to changes" or something like that

justinsb · 2020-07-30T11:31:36Z

generic/controllers/generic_controller.go

+	Channel string
+}
+
+// +kubebuilder:rbac:groups=addons.x-k8s.io,resources=generics,verbs=get;list;watch;create;update;patch;delete


I actually don't think we need these rbac permissions. I guess we want get/list/watch on generics, but you could also move than to main.go.

Is there any difference, moving it to main.go

justinsb · 2020-07-30T11:32:33Z

generic/controllers/generic_controller.go

+		return err
+	}
+
+	// Watch for changes to Generic


Nit: I think this should say "Watch for changes to the objectKind" or something like that

justinsb · 2020-07-30T11:33:58Z

This is looking really good! We do need the tools to generate the RBAC & the manifests, but then this is going to be a really nice experience for users!

cmoulliard · 2020-08-06T08:31:53Z

Can you please add a README.md file under the tools in order to explain how to use them with some concrete examples ?

cmoulliard · 2020-08-06T10:17:59Z

generic/Dockerfile

+FROM gcr.io/distroless/static:nonroot
+WORKDIR /
+COPY --from=builder /workspace/manager .
+COPY addons/ addons/


Error. The line COPY addons/ addons/ should be changed to COPY channels/ channels/ otherwise docker build will fail. @somtochiama

cmoulliard · 2020-08-06T10:30:38Z

I got this error when I run the generic controller under a kind cluster using the command make deploy

kc logs generic-controller-manager-5d9cf5db7b-mnfc2 -n generic-system -c manager
2020-08-06T10:27:56.581Z	INFO	controller-runtime.metrics	metrics server is starting to listen	{"addr": "127.0.0.1:8080"}
Please create a `Generic` resource

Why should we do then deploy first a Generic CRD before to start the controler ?

somtochiama · 2020-08-06T14:06:48Z

I got this error when I run the generic controller under a kind cluster using the command make deploy
kc logs generic-controller-manager-5d9cf5db7b-mnfc2 -n generic-system -c manager
2020-08-06T10:27:56.581Z	INFO	controller-runtime.metrics	metrics server is starting to listen	{"addr": "127.0.0.1:8080"}
Please create a `Generic` resource
Why should we do then deploy first a Generic CRD before to start the controler ?

The generic controller is different because it is used as a general controller for other simple addons that don't require any extra configuration.
The Generic resource is used to tell the generic controller these addons are and where to find their channels

somtochiama · 2020-08-06T14:07:06Z

Can you please add a README.md file under the tools in order to explain how to use them with some concrete examples ?

I will definitely do so

cmoulliard · 2020-08-06T14:51:20Z

The Generic resource is used to tell the generic controller these addons are and where to find their channels

Maybe then review the message logged to make it more explicit about root cause of the error and what is it needed to be done to avoid it. As the controller will crash, then we must find a way to make it healthy if a Generic CR has been deployed ...

somtochiama · 2020-08-07T08:09:09Z

Maybe then review the message logged to make it more explicit about root cause of the error and what is it needed to be done to avoid it.

I changed the message and added a REAME.md for the tools. Please review whenever you can! Thanks

justinsb · 2020-08-16T13:51:18Z

This is really cool and it sounds like people want to start trying it out, so let's merge it and iterate with further improvements!

/approve
/lgtm

k8s-ci-robot · 2020-08-16T13:51:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, SomtochiAma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [justinsb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

somtochiama added 4 commits July 23, 2020 17:00

Initial Scaffold

ab772bb

Creates CR for generic controller

ac573da

Uses WithManifest loader

6b02b33

Cleanup

4965def

k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 23, 2020

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 23, 2020

k8s-ci-robot requested review from dholbach and justinsb July 23, 2020 16:17

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 23, 2020

Uses SomtochiAma unstructured branch

703f80a

somtochiama force-pushed the generic-controller branch from eeb9e5a to 703f80a Compare July 23, 2020 16:19

k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 23, 2020

k8s-ci-robot removed the request for review from dholbach July 24, 2020 07:07

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 24, 2020

k8s-ci-robot requested a review from stealthybox July 24, 2020 07:07

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 24, 2020

justinsb reviewed Jul 30, 2020

View reviewed changes

somtochiama added 3 commits July 31, 2020 20:31

Removes comment

0add6c1

Adds the tool for generating manifest

f1d47cb

Adds skipped new files

d2a4e5f

cmoulliard reviewed Aug 6, 2020

View reviewed changes

Copies correct folder

47fa845

somtochiama added 2 commits August 7, 2020 08:51

Readme for generic addon and splits output into two files

0403bf1

Adds README.md for tools

88c65e4

somtochiama requested a review from justinsb August 7, 2020 08:07

Changes to README.de

21073c9

somtochiama mentioned this pull request Aug 14, 2020

REQUEST: New membership for SomtochiAma kubernetes/org#2107

Closed

6 tasks

Removes some comments

d69df19

k8s-ci-robot assigned justinsb Aug 16, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2020

k8s-ci-robot merged commit 55b1092 into kubernetes-sigs:master Aug 16, 2020

Generic controller #75

Generic controller #75

Uh oh!

Conversation

somtochiama commented Jul 23, 2020

Uh oh!

k8s-ci-robot commented Jul 23, 2020

Uh oh!

dholbach commented Jul 24, 2020

Uh oh!

justinsb Jul 30, 2020

Choose a reason for hiding this comment

Uh oh!

justinsb Jul 30, 2020

Choose a reason for hiding this comment

Uh oh!

justinsb Jul 30, 2020

Choose a reason for hiding this comment

Uh oh!

somtochiama Jul 31, 2020

Choose a reason for hiding this comment

Uh oh!

justinsb Jul 30, 2020

Choose a reason for hiding this comment

Uh oh!

justinsb commented Jul 30, 2020

Uh oh!

cmoulliard commented Aug 6, 2020

Uh oh!

cmoulliard Aug 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cmoulliard commented Aug 6, 2020

Uh oh!

somtochiama commented Aug 6, 2020

Uh oh!

somtochiama commented Aug 6, 2020

Uh oh!

cmoulliard commented Aug 6, 2020

Uh oh!

somtochiama commented Aug 7, 2020

Uh oh!

justinsb commented Aug 16, 2020

Uh oh!

k8s-ci-robot commented Aug 16, 2020

Uh oh!

Uh oh!

cmoulliard Aug 6, 2020 •

edited

Loading