Skip to content

Update dashboard operator golden tests #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Jun 5, 2020
Merged

Update dashboard operator golden tests #60

k8s-ci-robot merged 1 commit into from
Jun 5, 2020

Conversation

@rajansandeep
Copy link
Contributor

@rajansandeep rajansandeep commented Jun 4, 2020

Following #56, the output for the golden tests has changed.

This PR fixes the output by running HACK_AUTOFIX_EXPECTED_OUTPUT="true" go test ./...

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 4, 2020
@k8s-ci-robot k8s-ci-robot requested review from atoato88 and johnsonj June 4, 2020 21:55
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 4, 2020
@rajansandeep
Copy link
Contributor Author

rajansandeep commented Jun 4, 2020

/cc @somtochiama

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 4, 2020

@rajansandeep: GitHub didn't allow me to request PR reviews from the following users: SomtochiAma.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @somtochiama

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@somtochiama
Copy link
Contributor

somtochiama commented Jun 5, 2020

This looks great!

@johnsonj
Copy link

johnsonj commented Jun 5, 2020

Thank you @rajansandeep !

I filed #62 to setup these tests as part of presubmit.

@johnsonj
Copy link

johnsonj commented Jun 5, 2020

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 5, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnsonj, rajansandeep

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit c1d28a8 into kubernetes-sigs:master Jun 5, 2020
@atoato88 atoato88 mentioned this pull request Jun 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atoato88 atoato88 Awaiting requested review from atoato88

@johnsonj johnsonj Awaiting requested review from johnsonj

Assignees

@johnsonj johnsonj

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rajansandeep @k8s-ci-robot @somtochiama @johnsonj