Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates installer instructions for Mac OS #49

Closed
wants to merge 3 commits into from
Closed

Updates installer instructions for Mac OS #49

wants to merge 3 commits into from

Conversation

somtochiama
Copy link
Member

No description provided.

@somtochiama somtochiama changed the title Updates instructions for Mac OS Updates installer instructions for Mac OS Mar 18, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SomtochiAma
To complete the pull request process, please assign luxas
You can assign the PR to them by writing /assign @luxas in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@somtochiama
Copy link
Member Author

/assign @luxas

@atoato88
Copy link
Contributor

I tried make on Mac, and make success to build binary.
But its binary is Linux exec binary, not Mac exec binary.
The reason why you created PR is this?
If so, IMHO, how about update build target in Makefile to build Mac exec binary if run on Mac?

@justinsb @stealthybox
Any ideas?

@somtochiama
Copy link
Member Author

somtochiama commented Mar 24, 2020 •
edited
Loading

But its binary is Linux exec binary, not Mac exec binary.
The reason why you created PR is this?

Yes, that's the reason

If so, IMHO, how about update build target in Makefile to build Mac exec binary if run on Mac?

I could raise a PR for that

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 2, 2020
atoato88
atoato88 reviewed Apr 23, 2020
View reviewed changes
installer/Makefile Outdated
@@ -53,7 +54,13 @@ vendor:
go mod verify

only-build:
ifeq ($(UNAME),Darwin)
echo Darwin
make binary
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Mac, make binary is called and it calls autogen and vendor prerequisites, on the other hand, In Linux, this target calls $(MAKE) shell ... which doesn't call autogen and vendor prereqiusites.
So, this is not same action, I think.

How about change shell target to add GOOS and GOARCH on docker run in Mac?
When specify GOOS=darwin and GOARCH=amd64, go compiles binary for Mac.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 3, 2020
@somtochiama somtochiama requested a review from atoato88 July 3, 2020 00:39
@atoato88
Copy link
Contributor

atoato88 commented Jul 6, 2020

/lgtm
Thank you for update.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2020
@somtochiama somtochiama mentioned this pull request Aug 14, 2020
Closed
6 tasks
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 4, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 3, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb Awaiting requested review from justinsb

@stealthybox stealthybox Awaiting requested review from stealthybox

@atoato88 atoato88 Awaiting requested review from atoato88

Assignees

@atoato88 atoato88

@luxas luxas

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@somtochiama @k8s-ci-robot @atoato88 @fejta-bot @luxas