Skip to content

repository rename #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andyzhangx merged 2 commits into from
Aug 12, 2020
Merged

repository rename #209

andyzhangx merged 2 commits into from
Aug 12, 2020

Conversation

@andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Aug 9, 2020 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR should be the last big PR that

  • renames blobfuse-csi-driver to blob-csi-driver
  • provisioner name changed from blobfuse.csi.azure.com to blob.csi.azure.com.

We already added NFS support for this driver (only on Linux now), will add NFS support on Windows too in the near future.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

chore: repository rename

@andyzhangx andyzhangx requested review from ZeroMagic and chewong August 9, 2020 03:01
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 9, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 9, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 9, 2020
@k8s-ci-robot k8s-ci-robot requested a review from feiskyer August 9, 2020 03:01
@andyzhangx andyzhangx mentioned this pull request Aug 9, 2020
Merged
@andyzhangx
Copy link
Member Author

andyzhangx commented Aug 9, 2020

/hold
depends on PR: kubernetes/test-infra#18756

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2020
@chewong
Copy link
Member

chewong commented Aug 10, 2020

/retest

1 similar comment
@andyzhangx
Copy link
Member Author

andyzhangx commented Aug 11, 2020

/retest

@chewong
Copy link
Member

chewong commented Aug 11, 2020

https://github.com/kubernetes/test-infra/blob/master/kubetest/aksengine.go#L1272 needs to be changed before e2e tests start passing

@andyzhangx
Copy link
Member Author

andyzhangx commented Aug 11, 2020

https://github.com/kubernetes/test-infra/blob/master/kubetest/aksengine.go#L1272 needs to be changed before e2e tests start passing

thanks, filed a new PR: kubernetes/test-infra#18775

@ZeroMagic
Copy link
Contributor

ZeroMagic commented Aug 11, 2020

/retest

@andyzhangx
Copy link
Member Author

andyzhangx commented Aug 11, 2020

@ZeroMagic need around 2 days for kubernetes/test-infra#18775 to take effect(with kubetest binary updated)

@andyzhangx
Copy link
Member Author

andyzhangx commented Aug 12, 2020

/retest

@andyzhangx
Copy link
Member Author

andyzhangx commented Aug 12, 2020

rename repo completed!

@andyzhangx andyzhangx merged commit d2af992 into kubernetes-sigs:master Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chewong chewong Awaiting requested review from chewong

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andyzhangx @k8s-ci-robot @chewong @ZeroMagic