Skip to content

Conversation

@wongma7
Copy link
Contributor

@wongma7 wongma7 commented Jul 24, 2019

Is this a bug fix or adding new feature? new feature

What is this PR about? / Why do we need it? fixes #31 by adding https://github.com/kubernetes-csi/livenessprobe sidecar

also fixes #45 by prepending efs- to serviceaccount because I am touching the manifest here anyway.

What testing is done? on 1.14 cluster, created manifest. all containers report ready.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 24, 2019
@k8s-ci-robot k8s-ci-robot requested review from d-nishi and jsafrane July 24, 2019 19:23
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 24, 2019
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2019
@leakingtapan
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2019
@k8s-ci-robot k8s-ci-robot merged commit 4be290e into kubernetes-sigs:master Jul 31, 2019
RomanBednar pushed a commit to RomanBednar/aws-efs-csi-driver that referenced this pull request Jan 16, 2024
…nshift-master

OCPBUGS-25501: UPSTREAM: 1222: CVE-2023-48795: bump golang.org/x/crypto to v0.17.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update ServiceAccount, ClusterRole and ClusterRoleBinding name Integration with k8s liveness probe

3 participants