Skip to content

Security patch & upgrade of k8s.io/kubernetes, linux and golang #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 4 commits into from
Jan 21, 2022
Merged

Security patch & upgrade of k8s.io/kubernetes, linux and golang #619

k8s-ci-robot merged 4 commits into from
Jan 21, 2022

Conversation

@Ashley-wenyizha
Copy link
Contributor

@Ashley-wenyizha Ashley-wenyizha commented Jan 20, 2022

Is this a bug fix or adding new feature?

  • Security patch
  • Instruct docker build with no-cache

What is this PR about? / Why do we need it?
Security patching on

  1. k8s.io/kubernetes: upgrade to 1.23
  2. linux+golang security update

What testing is done?
Uploaded the image to dev account and mitigated all high risks and the majority of medium risks

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 20, 2022 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 20, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 20, 2022

Hi @Ashley-wenyizha. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 20, 2022
@Ashley-wenyizha Ashley-wenyizha changed the title Release 1.3 beta Security patch & upgrade of k8s.io/kubernetes, linux and golang Jan 20, 2022
wongma7
wongma7 reviewed Jan 20, 2022
View reviewed changes
Dockerfile Outdated
RUN GOOS=${TARGETOS} GOARCH=${TARGETARCH} make aws-efs-csi-driver

FROM amazonlinux:2
FROM amazonlinux:2.0.20211201.0
Copy link
Contributor

@wongma7 wongma7 Jan 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not need to pin it (the latest at buildtime should get picked up )

Copy link
Contributor Author

@Ashley-wenyizha Ashley-wenyizha Jan 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let me still keep FROM amazonlinux:2

@wongma7
Copy link
Contributor

wongma7 commented Jan 20, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 20, 2022
@Ashley-wenyizha
Copy link
Contributor Author

Ashley-wenyizha commented Jan 20, 2022

ECR enhanced scan after the upgrade
Screen Shot 2022-01-20 at 4 49 46 PM

@kbasv
Copy link

kbasv commented Jan 20, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2022
@wongma7
Copy link
Contributor

wongma7 commented Jan 20, 2022

After the 1.3.x release this change also should go in master branch as well ( I changed the default branch to release-1.3)

@wongma7
Copy link
Contributor

wongma7 commented Jan 21, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ashley-wenyizha, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3c6c851 into kubernetes-sigs:release-1.3 Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wongma7 wongma7 wongma7 left review comments

@jqmichael jqmichael Awaiting requested review from jqmichael

@leakingtapan leakingtapan Awaiting requested review from leakingtapan

Assignees

@kbasv kbasv

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Ashley-wenyizha @k8s-ci-robot @wongma7 @kbasv