Skip to content

Create a new AWS session with the region #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2021
Merged

Create a new AWS session with the region #435

merged 1 commit into from
May 15, 2021

Conversation

bodgit
Copy link
Contributor

@bodgit bodgit commented Apr 30, 2021 •
edited
Loading

Is this a bug fix or adding new feature?

Fixes #433

What is this PR about? / Why do we need it?

Rather than use a region-less session and configure the EFS client with the region from the metadata service, create a new session with the region. This way when AWS_STS_REGIONAL_ENDPOINTS=regional is set the session will return the correct STS endpoint.

What testing is done?

With this change, when I deploy the EFS driver to my EKS cluster with the aws-efs-csi-driver container patched to include the AWS_STS_REGIONAL_ENDPOINTS=regional environment variable it now works correctly and uses the sts.<region>.amazonaws.com endpoint. If I remove the environment variable or set it to legacy then it reverts back to using the sts.amazonaws.com endpoint which is the original behaviour.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Apr 30, 2021
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 30, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @bodgit!

It looks like this is your first PR to kubernetes-sigs/aws-efs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-efs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @bodgit. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 30, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 30, 2021
@bodgit
Create a new AWS session with the region
ed31b94 
Rather than use a region-less session and configure the EFS client with
the region from the metadata service, create a new session with the
region. This way when `AWS_STS_REGIONAL_ENDPOINTS=regional` is set the
session will return the correct STS endpoint.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 30, 2021
@wongma7
Copy link
Contributor

wongma7 commented Apr 30, 2021

I'm not that well-versed in the quirks of sdk client/session config but this looks right to me and i'll take your word for it. : D

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bodgit, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 30, 2021
@bodgit
Copy link
Contributor Author

bodgit commented May 4, 2021

/test pull-aws-efs-csi-driver-e2e

1 similar comment
@wongma7
Copy link
Contributor

wongma7 commented May 6, 2021

/test pull-aws-efs-csi-driver-e2e

@bodgit
Copy link
Contributor Author

bodgit commented May 6, 2021

Not sure if those test failures are related to my change or not?

@vxst
Copy link

vxst commented May 15, 2021 •
edited
Loading

Encountered the same problem, the changes lgtm.

I believed perhaps the testsuit should update the env set.

Should I try to do a commit on this or the testsuit is limited to AWS official?

@vxst
Copy link

vxst commented May 15, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit 3f1a79a into kubernetes-sigs:master May 15, 2021
@vxst
Copy link

vxst commented May 15, 2021

It seems that the default env works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-nishi d-nishi Awaiting requested review from d-nishi

@leakingtapan leakingtapan Awaiting requested review from leakingtapan

Assignees

@wongma7 wongma7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EFS driver doesn't use regional STS endpoint
4 participants
@bodgit @k8s-ci-robot @wongma7 @vxst