Expose env, volume, and volume mounts in helm chart for the efs controller and deamonset #1165
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
k8s-ci-robot
added
the
needs-rebase
cnmcavoy
force-pushed
the
cnmcavoy/helm-volumes-and-mounts
branch
from
faf5665
to
d27086b
Compare
k8s-ci-robot
removed
the
needs-rebase
|
Would love to see this get merged. It would be really useful to inject IAM configuration for non-EKS clusters. |
k8s-ci-robot
added
the
needs-rebase
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
There was a problem hiding this comment.
Hi @cnmcavoy , please undo changes to the versions in charts/aws-efs-csi-driver/CHANGELOG.md and charts/aws-efs-csi-driver/Chart.yaml, as we update these values as part of our release process
cnmcavoy
force-pushed
the
cnmcavoy/helm-volumes-and-mounts
branch
from
d27086b
to
142a464
Compare
k8s-ci-robot
added
size/S
k8s-ci-robot
removed
the
needs-rebase
|
+1 ... this would be very helpful |
|
+1 , hoping this can get merged very soon. |
|
/remove-lifecycle stale |
k8s-ci-robot
removed
the
lifecycle/stale
|
Is there an ETA for this? |
|
This is currently a blocking issue for me - I need to use a different CA certificate bundle when talking to the AWS API in my environment. Until this feature is merged I have no way to overwrite the CA bundle in the controller pods with the updated bundle I need to use. Would it help to create an issue to track this? |
|
{{ ping }} |
|
Issue created: #1349 |
|
@seanzatzdev-amazon it looks like the changes requested in this PR have been made - would you mind giving this another look? Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cnmcavoy, seanzatzdev-amazon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Is this a bug fix or adding new feature?
New Feature
What is this PR about? / Why do we need it?
Allows configuring the EFS CSI Controller and Daemonset for IRSA in helm values without relying on the IRSA webhook being installed and configured in a cluster.
What testing is done?
helm template produces the expected output.