Skip to content
This repository was archived by the owner on Sep 30, 2020. It is now read-only.

incorrect typha resources #1830

Merged
merged 1 commit into from
Feb 13, 2020
Merged

incorrect typha resources #1830

merged 1 commit into from
Feb 13, 2020

Conversation

alanbover
Copy link
Contributor

Seems that typha resources is lacking an "m" for refer to milicores.

In a normal cluster (without >250 cores per node) you get an error when
trying to create typha pods:

message: 'pods "calico-typha-857fd4bc7d-62jq6" is forbidden: maximum cpu usage
      per Container is 1, but limit is 250'

@alanbover
incorrect typha resources
733af28 
Seems that typha resources is lacking an "m" for refer to milicores.

In a normal cluster (without >250 cores per node) you get an error when
trying to create typha pods:

```
message: 'pods "calico-typha-857fd4bc7d-62jq6" is forbidden: maximum cpu usage
      per Container is 1, but limit is 250'
```
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 3, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @alanbover!

It looks like this is your first PR to kubernetes-incubator/kube-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-incubator/kube-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested a review from cknowles February 3, 2020 14:02
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 3, 2020
@k8s-ci-robot k8s-ci-robot requested a review from mumoshu February 3, 2020 14:02
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign mumoshu
You can assign the PR to them by writing /assign @mumoshu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-io
Copy link

Codecov Report

Merging #1830 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1830   +/-   ##
=======================================
  Coverage   24.59%   24.59%           
=======================================
  Files          98       98           
  Lines        5071     5071           
=======================================
  Hits         1247     1247           
  Misses       3684     3684           
  Partials      140      140
Impacted Files Coverage Δ
pkg/api/cluster.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6e6901...733af28. Read the comment docs.

@davidmccormick
Copy link
Contributor

/lgtm - thanks very much for this contribution!

@davidmccormick davidmccormick merged commit b34d9b6 into kubernetes-retired:master Feb 13, 2020
@davidmccormick davidmccormick added this to the v0.16.0 milestone Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cknowles cknowles Awaiting requested review from cknowles

@mumoshu mumoshu Awaiting requested review from mumoshu

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@alanbover @k8s-ci-robot @codecov-io @davidmccormick