Skip to content

feat: switch to csi-proxy GA v1 #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andyzhangx merged 4 commits into from
Jul 27, 2021
Merged

feat: switch to csi-proxy GA v1 #319

andyzhangx merged 4 commits into from
Jul 27, 2021

Conversation

@andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Jul 4, 2021

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: switch to csi-proxy GA v1

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

feat: switch to csi-proxy GA v1

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 4, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 4, 2021
@coveralls
Copy link

coveralls commented Jul 4, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1065864016

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.241%
Totals Coverage Status
Change from base Build 1064294704: 0.0%
Covered Lines: 796
Relevant Lines: 923
💛 - Coveralls

@andyzhangx andyzhangx mentioned this pull request Jul 5, 2021
Merged
@andyzhangx
Copy link
Member Author

andyzhangx commented Jul 5, 2021

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2021
@lizhuqi
Copy link
Contributor

lizhuqi commented Jul 16, 2021

/test pull-csi-driver-smb-e2e-gce

@lizhuqi
Copy link
Contributor

lizhuqi commented Jul 16, 2021

/retest pull-csi-driver-smb-e2e-gce

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 16, 2021

@lizhuqi: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

  • /test pull-csi-driver-smb-verify
  • /test pull-csi-driver-smb-unit
  • /test pull-csi-driver-smb-sanity
  • /test pull-csi-driver-smb-integration
  • /test pull-csi-driver-smb-windows-build
  • /test pull-csi-driver-smb-e2e
  • /test pull-csi-driver-smb-e2e-vmss
  • /test pull-csi-driver-smb-e2e-windows
  • /test pull-csi-driver-smb-external-e2e
  • /test pull-csi-driver-smb-e2e-gce

Use /test all to run the following jobs:

  • pull-csi-driver-smb-verify
  • pull-csi-driver-smb-unit
  • pull-csi-driver-smb-sanity
  • pull-csi-driver-smb-windows-build
  • pull-csi-driver-smb-e2e
  • pull-csi-driver-smb-e2e-vmss
  • pull-csi-driver-smb-e2e-windows
  • pull-csi-driver-smb-external-e2e
Details

In response to this:

/retest pull-csi-driver-smb-e2e-gce

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lizhuqi
Copy link
Contributor

lizhuqi commented Jul 16, 2021

/test pull-csi-driver-smb-e2e-gce

mauriciopoppe
mauriciopoppe reviewed Jul 21, 2021
View reviewed changes
@andyzhangx
feat: switch to csi-proxy GA v1
de5e1d6 
vendor csi-proxy v1.0.0
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2021
@andyzhangx andyzhangx changed the title [WIP]feat: switch to csi-proxy GA v1 feat: switch to csi-proxy GA v1 Jul 26, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2021
@andyzhangx
Copy link
Member Author

andyzhangx commented Jul 26, 2021

/test pull-csi-driver-smb-e2e-gce

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 26, 2021

@andyzhangx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-csi-driver-smb-e2e-gce 3adf8aa link /test pull-csi-driver-smb-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andyzhangx andyzhangx merged commit 298546a into kubernetes-csi:master Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

1 more reviewer

@mauriciopoppe mauriciopoppe mauriciopoppe left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@andyzhangx @k8s-ci-robot @coveralls @lizhuqi @mauriciopoppe