Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add details about cloud provider node name computation #8873

Merged
merged 1 commit into from
Jun 11, 2018
Merged

Add details about cloud provider node name computation #8873

merged 1 commit into from
Jun 11, 2018

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jun 2, 2018 •
edited
Loading

There is lots of confusion around how the following things interact to determine the name of a Kubernetes Node object:

  • the kubelet-determined hostname
  • the hostname as specified by --hostname-override
  • the behavior of --cloud-provider

this PR attempts to document the current state (what the kubelet does, what each cloud provider does, what the requirements of each cloud provider are on the Kubernetes Node name so other components can later find the instance via cloudprovider APIs, etc)

as providers allow more flexibility around this (efforts in progress, AWS, GCP, OpenStack), this documentation should be updated.

preview is at https://deploy-preview-8873--kubernetes-io-master-staging.netlify.com/docs/concepts/cluster-administration/cloud-providers/

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 2, 2018
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 2, 2018
@liggitt
Copy link
Member Author

liggitt commented Jun 2, 2018

@kubernetes/sig-aws-misc @kubernetes/sig-gcp-pr-reviews @kubernetes/sig-openstack-pr-reviews @kubernetes/sig-azure-pr-reviews @kubernetes/cloud-provider-vsphere-maintainers @kubernetes/cloud-provider-openstack-maintainers

@k8s-ci-robot k8s-ci-robot added area/provider/aws Issues or PRs related to aws provider area/provider/gcp Issues or PRs related to gcp provider area/provider/openstack Issues or PRs related to openstack provider area/provider/azure Issues or PRs related to azure provider labels Jun 2, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 325220b

https://deploy-preview-8873--kubernetes-io-master-staging.netlify.com

dims
dims reviewed Jun 2, 2018
View reviewed changes
content/en/docs/concepts/cluster-administration/cloud-providers.md

### Node Name

The OpenStack cloud provider uses the instance name (as determined from OpenStack metadata) as the name of the Kubernetes Node object.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

This was referenced Jun 2, 2018
Closed
Closed
Closed
Closed
Merged
feiskyer
feiskyer reviewed Jun 4, 2018
View reviewed changes
content/en/docs/concepts/cluster-administration/cloud-providers.md
### Node Name

The Azure cloud provider uses the hostname of the node (as determined by the kubelet or overridden with `--hostname-override`) as the name of the Kubernetes Node object.
Note that the Kubernetes Node name must match the Azure VM name.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mgdevstack pushed a commit to mgdevstack/kubernetes that referenced this pull request Jun 4, 2018
Merge pull request kubernetes#64661 from liggitt/hostname-override
50178d3 
Automatic merge from submit-queue (batch tested with PRs 63453, 64592, 64482, 64618, 64661). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Clarify --hostname-override and --cloud-provider interaction

pairs with a PR to the website cloud provider page defining behavior for existing cloud providers: kubernetes/website#8873

xref kubernetes#64659 kubernetes#62600 kubernetes#61774 kubernetes#54482

```release-note
NONE
```
nckturner
nckturner approved these changes Jun 5, 2018
View reviewed changes
content/en/docs/concepts/cluster-administration/cloud-providers.md
## Load Balancers
### Node Name

The AWS cloud provider uses the private DNS name of the AWS instance as the name of the Kubernetes Node object.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liggitt
Copy link
Member Author

liggitt commented Jun 7, 2018

@kubernetes/sig-docs-pr-reviews PTAL

This was based on code audits and reflects current behavior. Would like to see this merged and can iterate/expand as needed if folks from the remaining cloud providers have post-merge feedback

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 7, 2018
dims
dims approved these changes Jun 9, 2018
View reviewed changes
Copy link
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2018
@zacharysarah
Copy link
Contributor

@liggitt 👍
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2018
@k8s-ci-robot k8s-ci-robot merged commit 9743f4a into kubernetes:master Jun 11, 2018
@miracle2k miracle2k mentioned this pull request Oct 15, 2018
Closed
@seh seh mentioned this pull request Nov 25, 2018
Closed
@liggitt liggitt mentioned this pull request Jun 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@hogepodge hogepodge hogepodge left review comments

@nckturner nckturner nckturner approved these changes

@dims dims dims approved these changes

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider area/provider/azure Issues or PRs related to azure provider area/provider/gcp Issues or PRs related to gcp provider area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@liggitt @k8sio-netlify-preview-bot @zacharysarah @k8s-ci-robot @dims @hogepodge @feiskyer @nckturner