Skip to content

Add blog post for Structured Authn beta#45106

Merged
k8s-ci-robot merged 3 commits intokubernetes:mainfrom
aramase:aramase/d/kep_3331_beta_blog
Apr 19, 2024
Merged

Add blog post for Structured Authn beta#45106
k8s-ci-robot merged 3 commits intokubernetes:mainfrom
aramase:aramase/d/kep_3331_beta_blog

Conversation

@aramase
Copy link
Member

@aramase aramase commented Feb 12, 2024

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 12, 2024
@aramase
Copy link
Member Author

aramase commented Feb 12, 2024

/sig auth

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Feb 12, 2024
@netlify
Copy link

netlify bot commented Feb 12, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 0f926c1
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66144c397aa2f80008150589
😎 Deploy Preview https://deploy-preview-45106--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Feb 13, 2024

/area blog

@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label Feb 13, 2024
@fkautz
Copy link

fkautz commented Mar 12, 2024

Hi @aramase 👋🏽

I'm Frederick, a shadow from the Release Comms Team! #release-comms

I hope you're doing well! Just a friendly reminder that the deadline for the Kubernetes release blog post is coming up on March 22, 2024. When you have a draft ready for review, please update the 'Blog Status' to 'Ready for Review'.

Thank you so much for your time and contribution!

@sftim
Copy link
Contributor

sftim commented Mar 14, 2024

/hold
pending assignment of publication date

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2024
@kcmartin
Copy link
Contributor

@aramase 👋 Comms Team here, following up on your feature blog post for 1.30. The Ready for Review deadline is coming up this week on March 22, 2024. Please let us know if we can help out in any way!

@aramase aramase force-pushed the aramase/d/kep_3331_beta_blog branch from ac89c7f to f4c3640 Compare March 21, 2024 21:28
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 21, 2024
@aramase aramase force-pushed the aramase/d/kep_3331_beta_blog branch from f4c3640 to a252c3c Compare March 21, 2024 21:31
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 21, 2024
@aramase aramase marked this pull request as ready for review March 21, 2024 21:34
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2024
@aramase aramase force-pushed the aramase/d/kep_3331_beta_blog branch from a252c3c to e8ddece Compare March 21, 2024 21:41
@aramase
Copy link
Member Author

aramase commented Mar 21, 2024

/assign enj

@aramase aramase force-pushed the aramase/d/kep_3331_beta_blog branch from e8ddece to a0dec32 Compare March 22, 2024 01:29
Copy link
Member

@enj enj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments.

Signed-off-by: Anish Ramasekar <[email protected]>
@aramase aramase force-pushed the aramase/d/kep_3331_beta_blog branch from fae8820 to dffa687 Compare March 25, 2024 16:34
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2024
@aramase
Copy link
Member Author

aramase commented Mar 25, 2024

@kcmartin Do you know the publication date for the blog?

2024-04-29 is the publication date we assigned for this one

thanks @kcmartin!

I've updated the PR with the publication date.

@aramase
Copy link
Member Author

aramase commented Mar 25, 2024

We have a publication date now.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2024
@aramase
Copy link
Member Author

aramase commented Apr 1, 2024

@sftim @nate-double-u this PR is ready for review! PTAL

@sftim
Copy link
Contributor

sftim commented Apr 2, 2024

/hold

🛑 Do not merge until Kubernetes v1.30 is released 🛑

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2024
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Overall:

  • I would talk about using a file to configure authentication, rather than about Structured Authentication Configuration
  • avoid using “we” in the article as it can confuse readers about who you mean (for example, they might think you mean your employer, Microsoft)

If possible, avoid linking to the documentation. The ideal thing to do is to change the Kubernetes documentation to list the supported claim types directly so that people reading the announcement do not need to read source code.

@sftim
Copy link
Contributor

sftim commented Apr 2, 2024

Wait, how does this align with #45137 ?

I think we should put some work into telling readers how the two things are related.

@sftim
Copy link
Contributor

sftim commented Apr 2, 2024

@aramase you marked some feedback as resolved, but I didn't see any fixes. I've marked it as still needing a fix.

@aramase
Copy link
Member Author

aramase commented Apr 2, 2024

@aramase you marked some feedback as resolved, but I didn't see any fixes. I've marked it as still needing a fix.

@sftim I'm resolving them as I make changes locally (that's how I typically do it). I will push the changes when I'm done.

@sftim
Copy link
Contributor

sftim commented Apr 2, 2024

I'm resolving them as I make changes locally (that's how I typically do it). I will push the changes when I'm done.

Please don't do that, though: it makes life harder for reviewers, who can't tell the difference between something that will be fixed, and a misclick (or something else). I'm afraid with open source it's harder than I'd like to assume helpful intent.

Signed-off-by: Anish Ramasekar <[email protected]>
@aramase aramase requested a review from sftim April 8, 2024 19:58
@sftim
Copy link
Contributor

sftim commented Apr 9, 2024

/lgtm
/approve

🛑 Do not merge until Kubernetes v1.30 is released 🛑

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: 42ca2b76e960cda0e6018504dce93ccf9f318ca2

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2024
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8249a5b into kubernetes:main Apr 19, 2024
@aramase aramase deleted the aramase/d/kep_3331_beta_blog branch April 19, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

Archived in project
Status: Published

Development

Successfully merging this pull request may close these issues.

6 participants