Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add banner with message that legacy repos are getting frozen #42831

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Add banner with message that legacy repos are getting frozen #42831

merged 1 commit into from
Sep 1, 2023

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Sep 1, 2023 •
edited
Loading

This is a proposal to add a banner with the message that the legacy Google-hosted package repositories are now deprecated and will be frozen starting from September 13, 2023. The original announcement can be found here: https://k8s.io/linuxrepos

The banner is scheduled to go live from today until KubeCon NA 2023.

This change has NOT been discussed at all, so I'm putting this PR on hold until we don't reach consensus.
/hold

image

/assign @jeremyrickard
cc @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 1, 2023
@sftim
Copy link
Contributor

sftim commented Sep 1, 2023

/committee steering

@k8s-ci-robot k8s-ci-robot added the committee/steering Denotes an issue or PR intended to be handled by the steering committee. label Sep 1, 2023
sftim
sftim reviewed Sep 1, 2023
View reviewed changes
data/announcements/scheduled.yaml Outdated Show resolved Hide resolved
data/announcements/scheduled.yaml Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Sep 1, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e6ca831
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64f1ff588969330008c47b2d
😎 Deploy Preview https://deploy-preview-42831--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

chris-short
chris-short suggested changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@chris-short chris-short left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you for putting this together. I made some suggested edits. They are suggestions so feel free to riff on them how you see fit.

data/announcements/scheduled.yaml Outdated Show resolved Hide resolved
data/announcements/scheduled.yaml Outdated Show resolved Hide resolved
data/announcements/scheduled.yaml Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Sep 1, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 0630095
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64f20b78cec8b7000822d961
😎 Deploy Preview https://deploy-preview-42831--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 1, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 42dce20
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64f221f058c8820008d0a770
😎 Deploy Preview https://deploy-preview-42831--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Sep 1, 2023

Once this has LGTM, it's handy that you then squash it down to 1 commit @xmudrii. Not essential but a nice-to-have.

(And then Prow keeps the LGTM, and you unhold, and it merges)

palnabarun
palnabarun approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@palnabarun palnabarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
(with the steering hat)

/hold for steering consensus

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0277f4f8543f42eaeaec596e6e461f629195ac89

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2023
@reylejano
Copy link
Member

/lgtm

justaugustus
justaugustus approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve (Steering & SIG Release)

@xmudrii
Copy link
Member Author

xmudrii commented Sep 1, 2023

@sftim Squashed all the commits into one

@mrbobbytables
Copy link
Member

/approve
with steering hat

@cblecker
Copy link
Member

cblecker commented Sep 1, 2023

/approve

@tpepper
Copy link
Member

tpepper commented Sep 1, 2023

/approve
(Steering)

justaugustus
justaugustus approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've got a majority from Steering!
/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2023
@palnabarun
Copy link
Member

Steering consensus is achieved with 5 votes from (@palnabarun, @justaugustus, @mrbobbytables, @cblecker, @tpepper).

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, justaugustus, mrbobbytables, palnabarun, tpepper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 16c6c2b into kubernetes:main Sep 1, 2023
4 checks passed
BenTheElder
BenTheElder reviewed Sep 1, 2023
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@xmudrii xmudrii deleted the freezing-repos-banner branch September 1, 2023 20:02
@xmudrii
Copy link
Member Author

xmudrii commented Sep 1, 2023

Thanks a lot everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyrickard jeremyrickard jeremyrickard left review comments

@sftim sftim sftim left review comments

@BenTheElder BenTheElder BenTheElder left review comments

@chris-short chris-short chris-short requested changes

@palnabarun palnabarun palnabarun approved these changes

@justaugustus justaugustus justaugustus approved these changes

@cpanato cpanato Awaiting requested review from cpanato

@tpepper tpepper Awaiting requested review from tpepper

Assignees

@justaugustus justaugustus

@palnabarun palnabarun

@jeremyrickard jeremyrickard

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.