Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[es] Correción documentación Network Policy #42617

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

jonathino2590
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the language/es Issues or PRs related to Spanish language label Aug 17, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 17, 2023
@netlify
Copy link

netlify bot commented Aug 17, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 9ac1906
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64e66023498aa50008182ba8
😎 Deploy Preview https://deploy-preview-42617--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

{{< /note >}}


## Como apuntar a un Namespace usando su nombre
## Cómo apuntar a un Namespace usando su nombre
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No estoy seguro si al utilizar los signos de interrogación podría afectar el rendering del documento

Suggested change
## Cómo apuntar a un Namespace usando su nombre
## ¿Cómo apuntar a un Namespace usando su nombre?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deseas que haga un commit con ese cambio para ver como se ve?

[Configurar un Pod para usar un ConfigMap](/docs/tasks/configure-pod-container/configure-pod-configmap/),
y [Gestión de Objetos](/docs/concepts/overview/working-with-objects/object-management).

__spec__: NetworkPolicy [spec](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#spec-and-status) contiene toda la información necesaria para definir una política de red dado un Namespace.

__podSelector__: Cada NetworkPolicy incluye un `podSelector` el cual selecciona el grupo de Pods en los cuales aplica la política. La política de ejemplo selecciona Pods con el label "role=db". Un `podSelector` vacío selecciona todos los Pods en un Namespace.
__podSelector__: Cada NetworkPolicy incluye un `podSelector` el cual selecciona el grupo de Pods en los cuales aplica la política. La política de ejemplo selecciona Pods con la etiqueta "role=db". Un `podSelector` vacío selecciona todos los Pods en un Namespace.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@electrocucaracha que es mejor dejarlo con label o como etiqueta, por lo que veo q estan las dos formar en mi PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me parece que en algún momento se decidió dejarlo como etiqueta, más nunca se mantuvo esa regla

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Por lo que veo en el documento que me adjuntas tiene las dos definiciones

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krol3 @ramrodo @92nqb quizá sería bueno discutir este punto la próxima reunión semanal

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me parece que usar "etiqueta" es lo adecuado. Aquí unos ejemplos de otras documentaciones:

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some ideas. Yo hablo pequeño español.

@jonathino2590
Copy link
Contributor Author

@electrocucaracha Se necesita algo adicional para este Pr?

@electrocucaracha
Copy link
Contributor

@electrocucaracha Se necesita algo adicional para este Pr?

/lgtm

En general lo veo bien, me gustaría que los demás lo revisaran

/cc @ramrodo @92nqb y/o @krol3

@k8s-ci-robot
Copy link
Contributor

@electrocucaracha: GitHub didn't allow me to request PR reviews from the following users: y/o.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@electrocucaracha Se necesita algo adicional para este Pr?

/lgtm

En general lo veo bien, me gustaría que los demás lo revisaran

/cc @ramrodo @92nqb y/o @krol3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 12d5062ef628bc8006dc9e56a2929942349d557f

@jonathino2590
Copy link
Contributor Author

@electrocucaracha este se tiene algo pendiente?

Copy link
Member

@ramrodo ramrodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Gracias por la contribución @jonathino2590!

(disculpa la demora en revisarlo)

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ramrodo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit b2888c9 into kubernetes:main Sep 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/es Issues or PRs related to Spanish language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants