Skip to content

Setup branch protection for cli-runtime and sample-cli-plugin #9292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Sep 7, 2018
Merged

Setup branch protection for cli-runtime and sample-cli-plugin #9292

k8s-ci-robot merged 1 commit into from
Sep 7, 2018

Conversation

@spiffxp
Copy link
Contributor

@spiffxp spiffxp commented Sep 7, 2018

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/prow Issues or PRs related to prow labels Sep 7, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2018
@cblecker
Copy link
Member

cblecker commented Sep 7, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2018
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 7, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d21cc85 into kubernetes:master Sep 7, 2018
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 7, 2018

@spiffxp: Updated the config configmap using the following files:

  • key config.yaml using file prow/config.yaml
Details

In response to this:

ref: kubernetes/org#58

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the protect-cli-repos branch September 7, 2018 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cblecker cblecker Awaiting requested review from cblecker

@cjwagner cjwagner Awaiting requested review from cjwagner

@0xmichalis 0xmichalis Awaiting requested review from 0xmichalis

Assignees

@cblecker cblecker

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@spiffxp @cblecker @k8s-ci-robot