-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Update to go1.11.5 and go1.10.8 #10957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also use bazel 0.21.0 for testing the Kubernetes master branch.
/lgtm Should k/k go in first? |
LGTM label has been added. Git tree hash: a17e4c746fec43ae69354589beb976b37c16ea13
|
…er|experimental|releases) (using generate_tests and manual)
Built an new kubekins-test image and update its references (we're close to being able to remove that one though, right @krzyzacy?), as well as kubekins-e2e. I also built and pushed a new gcloud-in-go image, but I didn't update its uses anywhere since I'm not sure how safe that is (and a bunch of jobs seem to use wildly different versions of it). |
cc @amwat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold
LGTM label has been added. Git tree hash: 3cc472863a3bbdfd22160fa5e608a66e654f3f73
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, ixdy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
@ixdy: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Also use bazel 0.21.0 for testing the Kubernetes master branch. (It's been fine on test-infra, and I've also used bazel 0.21.0 locally for quite some time.)
x-ref kubernetes/kubernetes#73238
I can bump kubekins-test and kubekins-e2e in this PR if we'd like, too.
/assign @BenTheElder @cblecker