Skip to content

api: Allow MaxSurge to be set on DaemonSets during update #96375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 4 commits into from
Dec 17, 2020
Merged

api: Allow MaxSurge to be set on DaemonSets during update #96375

k8s-ci-robot merged 4 commits into from
Dec 17, 2020

Conversation

@smarterclayton
Copy link
Contributor

@smarterclayton smarterclayton commented Nov 9, 2020

MaxSurge allows a daemonset workload to run multiple instances of the same pod on a node during rollout to minimize downtime of the daemonset to other consumers.

This PR adds the feature gate and API for kubernetes/enhancements#1591 and configures round tripping behavior when the gate is enabled or disabled as well as validation rules to prevent inconsistent values. Subsequent PRs will add implementation.

/kind feature
/kind api-change

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/1591-daemonset-surge

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 9, 2020
@smarterclayton
Copy link
Contributor Author

smarterclayton commented Nov 9, 2020

/sig apps

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 9, 2020
@fejta-bot
Copy link

fejta-bot commented Nov 9, 2020

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@smarterclayton
Copy link
Contributor Author

smarterclayton commented Nov 9, 2020

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 9, 2020
@derekwaynecarr derekwaynecarr removed their request for review November 9, 2020 19:46
@smarterclayton
Copy link
Contributor Author

smarterclayton commented Nov 9, 2020

/assign @kubernetes/sig-apps-pr-reviews

@smarterclayton smarterclayton mentioned this pull request Nov 9, 2020
Merged
@soltysh
Copy link
Contributor

soltysh commented Nov 10, 2020

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 10, 2020
soltysh
soltysh approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, the rest lgtm.
/assign @janetkuo @kow3ns @tnozicka

@fejta-bot
Copy link

fejta-bot commented Dec 12, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

3 similar comments
@fejta-bot
Copy link

fejta-bot commented Dec 12, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

fejta-bot commented Dec 12, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

fejta-bot commented Dec 12, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kow3ns
Copy link
Member

kow3ns commented Dec 14, 2020 •
edited
Loading

/approve

@smarterclayton
Copy link
Contributor Author

smarterclayton commented Dec 16, 2020

/test all

@smarterclayton
Copy link
Contributor Author

smarterclayton commented Dec 16, 2020

/test pull-kubernetes-e2e-gce-ubuntu-containerd
/test pull-kubernetes-node-e2e
/test pull-kubernetes-e2e-gce-100-performance

@smarterclayton
Copy link
Contributor Author

smarterclayton commented Dec 17, 2020

/refresh

@smarterclayton
Copy link
Contributor Author

smarterclayton commented Dec 17, 2020

/test pull-kubernetes-e2e-gce-100-performance
/test pull-kubernetes-e2e-gce-ubuntu-containerd
/test pull-kubernetes-node-e2e

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 17, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janetkuo, kow3ns, smarterclayton, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims
Copy link
Member

dims commented Dec 17, 2020

/test all

@smarterclayton
api: Add DaemonSet MaxSurge
5aa53f8 
The MaxSurge field on DaemonSet rolling updates allows a daemonset
workload to have two pods running simultaneously on a node during
an update in order to perform zero-disruption handoffs of client
traffic.
@smarterclayton
generated: Changes for DaemonSet max surge
ac77b38
@smarterclayton
feature: Add DaemonSetUpdateSurge feature gate
4a23269
@smarterclayton
validation: Handle presence of MaxSurge on DaemonSet
c37c93f 
When the maxsurge daemonset gate is disabled, the registry and validation
must properly handle stripping the field. In the special case where that
would leave the MaxUnavailable field set to 0, we must set it to 1 which
is the default value.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2020
@dims
Copy link
Member

dims commented Dec 17, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2020
@smarterclayton
Copy link
Contributor Author

smarterclayton commented Dec 17, 2020

/retest

@dims
Copy link
Member

dims commented Dec 17, 2020

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@k8s-ci-robot k8s-ci-robot merged commit fa2787a into kubernetes:master Dec 17, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Dec 17, 2020
This was referenced Dec 18, 2020
Closed
Merged
@smarterclayton
Copy link
Contributor Author

smarterclayton commented Jan 22, 2021

Implementation PR is ready for review in #96441

@wking wking mentioned this pull request Apr 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soltysh soltysh soltysh approved these changes

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

+2 more reviewers

@tnozicka tnozicka tnozicka left review comments

@janetkuo janetkuo janetkuo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dims dims

@janetkuo janetkuo

@kow3ns kow3ns

@tnozicka tnozicka

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

v1.21

Development

Successfully merging this pull request may close these issues.

8 participants

@smarterclayton @fejta-bot @soltysh @janetkuo @kow3ns @k8s-ci-robot @dims @tnozicka