Skip to content

Fix GKE upgrade test. #85555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Nov 24, 2019
Merged

Fix GKE upgrade test. #85555

k8s-ci-robot merged 1 commit into from
Nov 24, 2019
+1 −1

Conversation

@Random-Liu
Copy link
Member

@Random-Liu Random-Liu commented Nov 22, 2019 •
edited
Loading

Fix GKE upgrade test failure introduced by #84174.

We get the following error:

ERROR: (gcloud.container.node-pools.list) Name expected [
     table(
        name,
        config.machineType,
        config.diskSizeGb,
        version:label=NODE_VERSION
     )
 *HERE* "get(name)"].

The reason is that the format is passed in with "quotes", and gcloud doesn't understand it.

We should cherry-pick this into 1.17 to fix the upgrade test.

Signed-off-by: Lantao Liu [email protected]

none

@Random-Liu Random-Liu added kind/bug Categorizes issue or PR as related to a bug. area/test priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Nov 22, 2019
@Random-Liu Random-Liu added this to the v1.17 milestone Nov 22, 2019
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 22, 2019
@Random-Liu
Fix GKE upgrade test.
73a881e 
Signed-off-by: Lantao Liu <[email protected]>
@Random-Liu Random-Liu added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Nov 22, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 22, 2019
@k8s-ci-robot k8s-ci-robot added the area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework label Nov 22, 2019
@Random-Liu
Copy link
Member Author

Random-Liu commented Nov 22, 2019

/test pull-kubernetes-integration

@BenTheElder
Copy link
Member

BenTheElder commented Nov 24, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 24, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, Random-Liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2343a67 into kubernetes:master Nov 24, 2019
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.17, v1.18 Nov 24, 2019
@Random-Liu Random-Liu deleted the fix-upgrade-test branch November 26, 2019 22:56
@Random-Liu Random-Liu mentioned this pull request Nov 26, 2019
Merged
k8s-ci-robot added a commit that referenced this pull request Nov 28, 2019
@k8s-ci-robot
Merge pull request #85658 from Random-Liu/automated-cherry-pick-of-#8…
f0e172d 
…5555-upstream-release-1.17

Automated cherry pick of #85555: Fix GKE upgrade test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees

@BenTheElder BenTheElder

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.18

Development

Successfully merging this pull request may close these issues.

3 participants

@Random-Liu @BenTheElder @k8s-ci-robot