Skip to content

Revert "kube-proxy: check KUBE-MARK-DROP" #85527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Nov 23, 2019
Merged

Revert "kube-proxy: check KUBE-MARK-DROP" #85527

k8s-ci-robot merged 1 commit into from
Nov 23, 2019
+1 −2

Conversation

@aojea
Copy link
Member

@aojea aojea commented Nov 22, 2019 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

This reverts commit 1ca0ffe.

kube-proxy is not recreating the rules associated to the
KUBE-MARK-DROP chain, that is created by the kubelet.

Is preferrable to avoid the dependency between the kubelet and
kube-proxy, so each of them handles their own rules.

Which issue(s) this PR fixes:

Fixes #85414

Special notes for your reviewer:

This is only needed for kube-proxy operating in dual-stack with iptables, and that PR wasn't merged.
Also, there is a discussion about this topic with a better solution than this
#82125 (comment)

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@aojea
Revert "kube-proxy: check KUBE-MARK-DROP"
98be783 
This reverts commit 1ca0ffe.

kube-proxy is not recreating the rules associated to the
KUBE-MARK-DROP chain, that is created by the kubelet.

Is preferrable avoid the dependency between the kubelet and
kube-proxy and that each of them handle their own rules.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 22, 2019
@aojea
Copy link
Member Author

aojea commented Nov 22, 2019

/assign @danwinship @thockin

my apologies for introducing this bug
/sig network

@aojea
Copy link
Member Author

aojea commented Nov 22, 2019

/priority critical-urgent
/milestone v1.17

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 22, 2019

@aojea: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

Details

In response to this:

/priority critical-urgent
/milestone v1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 22, 2019
@danwinship
Copy link
Contributor

danwinship commented Nov 23, 2019

Ugh, yeah, it looks like every time the proxier syncs, it deletes the contents of kubelet's KUBE-MARK-DROP chain. That's bad. (The fact that we apparently have no tests that KUBE-MARK-DROP is working correctly is also bad.)

So this fix is correct, and removing it won't break anything (because it was only half of the fix anyway) and this is absolutely needed for 1.17, beyond just fixing the flaky test.

/lgtm
/approve

(I don't have milestone bits either but @thockin should notice this when he gets back to work. Or it looks like @khenidak could set the milestone.)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, danwinship

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2019
@dims
Copy link
Member

dims commented Nov 23, 2019

/milestone v1.17

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 23, 2019
@aojea aojea mentioned this pull request Nov 23, 2019
Merged
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 23, 2019
@danwinship danwinship mentioned this pull request Nov 23, 2019
Closed
@danwinship
Copy link
Contributor

danwinship commented Nov 23, 2019

(The fact that we apparently have no tests that KUBE-MARK-DROP is working correctly is also bad.)

#85572

@danwinship danwinship mentioned this pull request Nov 23, 2019
Closed
@aojea
Copy link
Member Author

aojea commented Nov 23, 2019

/test pull-kubernetes-e2e-gce
timed out 🤔

@aojea
Copy link
Member Author

aojea commented Nov 23, 2019

/test pull-kubernetes-e2e-gce
Failed test
k8s.io] Pods should support pod readiness gates [NodeFeature:PodReadinessGate

@k8s-ci-robot k8s-ci-robot merged commit 459b1d7 into kubernetes:master Nov 23, 2019
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.17, v1.18 Nov 23, 2019
k8s-ci-robot added a commit that referenced this pull request Nov 24, 2019
@k8s-ci-robot
Merge pull request #85570 from aojea/automated-cherry-pick-of-#85527-…
15addaa 
…upstream-release-1.17

Automated cherry pick of #85527: Revert "kube-proxy: check KUBE-MARK-DROP"
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 9, 2019
@aojea aojea mentioned this pull request May 6, 2020
Closed
@aojea aojea mentioned this pull request Sep 7, 2020
Merged
@danwinship danwinship mentioned this pull request Feb 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@nicksardo nicksardo Awaiting requested review from nicksardo

Assignees

@danwinship danwinship

@thockin thockin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.18

Development

Successfully merging this pull request may close these issues.

[Flaky test] gce-cos-master-alpha-features (ci-kubernetes-e2e-gci-gce-alpha-features)

5 participants

@aojea @k8s-ci-robot @danwinship @dims @thockin