Skip to content

Initialize FeatureGate map for KubeProxy config. #1929 #85524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Nov 22, 2019
Merged

Initialize FeatureGate map for KubeProxy config. #1929 #85524

k8s-ci-robot merged 1 commit into from
Nov 22, 2019

Conversation

@Arvinderpal
Copy link
Contributor

@Arvinderpal Arvinderpal commented Nov 22, 2019 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
kubernetes/kubeadm#1929

Which issue(s) this PR fixes:
Fixes kubernetes/kubeadm#1929

Does this PR introduce a user-facing change?:

kubeadm: fix a panic in case the KubeProxyConfiguration feature gates were not initialized.

@neolit123 @rosti

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 22, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 22, 2019

Hi @Arvinderpal. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 22, 2019
@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 22, 2019
rosti
rosti approved these changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@rosti rosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Arvinderpal !
Can you also add a release note to the PR?
/ok-to-test
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 22, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Arvinderpal, rosti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2019
@rosti
Copy link
Contributor

rosti commented Nov 22, 2019

/retest

@neolit123
Copy link
Member

neolit123 commented Nov 22, 2019

/priority important-soon
/milestone v1.17

Can you also add a release note to the PR?

yes, something in the lines of:

kubeadm: fix a panic in case the KubeProxyConfiguration feature gates were not initialized

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Nov 22, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 22, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 22, 2019
@Arvinderpal
Copy link
Contributor Author

Arvinderpal commented Nov 22, 2019

@neolit123 I added the release note.

@neolit123
Copy link
Member

neolit123 commented Nov 22, 2019 •
edited
Loading

do-not-merge/release-note-label-needed

@Arvinderpal
release notes need to follow a special formatting using a release-note block
please see here:
https://raw.githubusercontent.com/kubernetes/kubernetes/master/.github/PULL_REQUEST_TEMPLATE.md

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 22, 2019
@Arvinderpal
Copy link
Contributor Author

Arvinderpal commented Nov 22, 2019

Done.

@neolit123
Copy link
Member

neolit123 commented Nov 22, 2019

thanks
/lgtm

i will send backport for 1.16

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3028dc1 into kubernetes:master Nov 22, 2019
@neolit123 neolit123 mentioned this pull request Nov 22, 2019
Closed
@Arvinderpal Arvinderpal mentioned this pull request Nov 27, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kad kad Awaiting requested review from kad

@yagonobre yagonobre Awaiting requested review from yagonobre

1 more reviewer

@rosti rosti rosti approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@neolit123 neolit123

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.17

Development

Successfully merging this pull request may close these issues.

panic: assignment to entry in nil map in KubeProxy FeatureGate Configuration

4 participants

@Arvinderpal @k8s-ci-robot @rosti @neolit123