Skip to content

Set node cidr mask size ipv4/ipv6 config #85500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Nov 23, 2019
Merged

Set node cidr mask size ipv4/ipv6 config #85500

k8s-ci-robot merged 1 commit into from
Nov 23, 2019
+2 −0

Conversation

@aramase
Copy link
Member

@aramase aramase commented Nov 21, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #85491

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 21, 2019
@aramase
Copy link
Member Author

aramase commented Nov 21, 2019 •
edited
Loading

/priority critical-urgent
/milestone v1.17

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 21, 2019

@aramase: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

Details

In response to this:

/priority important-soon
/milestone v1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 21, 2019
@aramase
Copy link
Member Author

aramase commented Nov 21, 2019

/assign @thockin

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Nov 21, 2019
@aramase
Copy link
Member Author

aramase commented Nov 21, 2019

/test pull-kubernetes-conformance-kind-ipv6

@aojea
Copy link
Member

aojea commented Nov 21, 2019

don't we have any test covering this?
or is it going to be implemented in a follow up PR?

@aramase
Copy link
Member Author

aramase commented Nov 21, 2019

The options_test check for AddFlags but don't check the ApplyTo. I'll be adding that in a follow up PR and also will be implementing e2e tests.

@josiahbjorgaard
Copy link
Contributor

josiahbjorgaard commented Nov 21, 2019

/milestone v1.17

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 21, 2019
@liggitt
Copy link
Member

liggitt commented Nov 22, 2019

+1 for covering test case

@aojea
Copy link
Member

aojea commented Nov 23, 2019

/assign @deads2k

thockin
thockin reviewed Nov 23, 2019
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2019
@aramase aramase mentioned this pull request Nov 23, 2019
Merged
@aramase
Copy link
Member Author

aramase commented Nov 23, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit d50717d into kubernetes:master Nov 23, 2019
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.17, v1.18 Nov 23, 2019
@aramase aramase deleted the fix-85491 branch November 23, 2019 20:39
k8s-ci-robot added a commit that referenced this pull request Nov 24, 2019
@k8s-ci-robot
Merge pull request #85573 from aramase/automated-cherry-pick-of-#8550…
548b8b6 
…0-upstream-release-1.17

Automated cherry pick of #85500: Set node cidr mask size ipv4/ipv6 config
@aramase aramase mentioned this pull request Nov 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thockin thockin thockin left review comments

@gmarek gmarek Awaiting requested review from gmarek

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@thockin thockin

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.18

Development

Successfully merging this pull request may close these issues.

node-cidr-mask-size-ipv6 can not work

7 participants

@aramase @k8s-ci-robot @aojea @josiahbjorgaard @liggitt @thockin @deads2k