Skip to content

Remove metric be hidden log temporarily #85402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Nov 22, 2019
Merged

Remove metric be hidden log temporarily #85402

k8s-ci-robot merged 1 commit into from
Nov 22, 2019

Conversation

@RainbowMango
Copy link
Member

@RainbowMango RainbowMango commented Nov 18, 2019 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
Remove warning logs from binaries --version command.

This is a quick fix of the issue, we need to consider more about the way a metric be registered.

Which issue(s) this PR fixes:
Fixes #85369

Special notes for your reviewer:
According to @liggitt 's comments, if this PR is acceptable, we should cherry-pick to branch release-1.17.

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 18, 2019
@RainbowMango RainbowMango mentioned this pull request Nov 18, 2019
Closed
@liggitt
Copy link
Member

liggitt commented Nov 18, 2019

I'm not very familiar with the desired behavior of the deprecated metrics, the warning message, or the flag that is intended to re-enable deprecated metrics

/cc @logicalhan @lavalamp

@RainbowMango
Copy link
Member Author

RainbowMango commented Nov 18, 2019

Things more serious than the warning log is that if people register metrics by init() the flag --show-hidden-metrics-for-version will not work. Because if a metric has been deprecated by stability framework, we can't enable it again by --show-hidden-metrics-for-version.

/assign @logicalhan @brancz
/milestone v1.17

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 18, 2019
@RainbowMango RainbowMango mentioned this pull request Nov 18, 2019
Closed
@RainbowMango
Copy link
Member Author

RainbowMango commented Nov 18, 2019

There are two issues we should deal with:

And this PR focus on the first issue.

@dims
Copy link
Member

dims commented Nov 18, 2019

/assign @liggitt

happy to do this for 1.17 and deal with the other things pointed out later

LGTM

@liggitt liggitt removed their assignment Nov 19, 2019
@brancz
Copy link
Member

brancz commented Nov 21, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2019
@fejta-bot
Copy link

fejta-bot commented Nov 21, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

fejta-bot commented Nov 22, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@RainbowMango
Copy link
Member Author

RainbowMango commented Nov 22, 2019

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot merged commit d87c921 into kubernetes:master Nov 22, 2019
@RainbowMango RainbowMango mentioned this pull request Nov 22, 2019
Closed
@RainbowMango RainbowMango deleted the pr_remove_metrics_hidden_log branch June 16, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coffeepac coffeepac Awaiting requested review from coffeepac

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

@lavalamp lavalamp Awaiting requested review from lavalamp

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@logicalhan logicalhan

@brancz brancz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.17

Development

Successfully merging this pull request may close these issues.

1.17/1.18 kubelet prints a klog.Warning from --version

7 participants

@RainbowMango @liggitt @dims @brancz @k8s-ci-robot @fejta-bot @logicalhan