Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ut for scheduler framework #85188

Merged
merged 1 commit into from
Nov 23, 2019
Merged

add ut for scheduler framework #85188

merged 1 commit into from
Nov 23, 2019

Conversation

charleszheng44
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR adds UT for scheduler framework

Which issue(s) this PR fixes:
Ref #80272

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 13, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @charleszheng44. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@charleszheng44 charleszheng44 mentioned this pull request Nov 13, 2019
Closed
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 13, 2019
@liu-cong
Copy link
Contributor

/assign

@liu-cong
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 13, 2019
@charleszheng44
Copy link
Contributor Author

/retest

liu-cong
liu-cong reviewed Nov 14, 2019
View reviewed changes
@liu-cong
Copy link
Contributor

Thanks Chao!

One last thing, can you squash your commits into a single commit and update the message to add unit test for scheduler framework RunFilterPlugin?

I will LGTM.

@charleszheng44
Copy link
Contributor Author

Thanks Chao!

One last thing, can you squash your commits into a single commit and update the message to add unit test for scheduler framework RunFilterPlugin?

I will LGTM.

Thanks for go through the whole process with me!

@liu-cong
Copy link
Contributor

There is an error

--- FAIL: TestFilterPlugins/ErrorAndSuccessFilters (0.00s)
        framework_test.go:748: Wrong status code. got: Success, want:Error

I couldn't figured out why by quick glance. @charleszheng44 Can you debug it?

@charleszheng44
Copy link
Contributor Author

There is an error

--- FAIL: TestFilterPlugins/ErrorAndSuccessFilters (0.00s)
        framework_test.go:748: Wrong status code. got: Success, want:Error

I couldn't figured out why by quick glance. @charleszheng44 Can you debug it?

Hi Cong, the issue is that the PluginFactory is a function type and. Since I call the registry.Register function inside a loop of slice iteration. the registry.Register will keep adding the last plugin into the registry. (e.g. [Error, Success] become [Success, Success]) Once I deepcopy each plugin, the test is passed. Sorry for my careless mistake.

liu-cong
liu-cong reviewed Nov 15, 2019
View reviewed changes
pkg/scheduler/framework/v1alpha1/framework_test.go Outdated
cfgPls := &config.Plugins{Filter: &config.PluginSet{}}
for _, pl := range tt.plugins {
// register all plugins
// deepcopy the plugin struct
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete the comment, it's not relevant any more

@liu-cong
Copy link
Contributor

/lgtm

Thanks @charleszheng44 !

@ahg-g, can you approve?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2019
@liu-cong
Copy link
Contributor

/retest

2 similar comments
@liu-cong
Copy link
Contributor

/retest

@liu-cong
Copy link
Contributor

/retest

@ahg-g
Copy link
Member

ahg-g commented Nov 15, 2019

/approve

Thanks for adding the unit test.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, charleszheng44

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2019
@liu-cong
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit a15b5df into kubernetes:master Nov 23, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Nov 23, 2019
@charleszheng44 charleszheng44 mentioned this pull request Jul 13, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liu-cong liu-cong liu-cong left review comments

@hex108 hex108 Awaiting requested review from hex108

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

Assignees

@liu-cong liu-cong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
4 participants
@charleszheng44 @k8s-ci-robot @liu-cong @ahg-g