Move external facing kubelet apis to staging #83551

dims · 2019-10-06T19:46:12Z

What type of PR is this?
/kind api-change
/area code-organization

What this PR does / why we need it:
deviceplugin and pluginregistration are external facing APIs. currently we are forcing folks to import them from k8s.io/kubernetes which is not optimal. We should instead make them available from the k8s.io/kubelet repo to make it easier for them.

Which issue(s) this PR fixes:

Related to #82437

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

external facing APIs in pluginregistration and deviceplugin packages are now available under k8s.io/kubelet/pkg/apis/

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Change-Id: I06adcb43bd278b430ffad2010869e1524c8cc4ff

Change-Id: Ia3917cec1453c0b22a958faf8c22bccd79242d14

dims · 2019-10-06T19:46:30Z

/sig node
/priority important-soon

Change-Id: Ib5a0d3b3e9bd1505a263064f35bea3514c992e4a

klueska · 2019-10-06T20:29:34Z

What implications does this have if we have changes to these APIs in future releases? I know of at least one addition to the device plugin API coming in 1.17.

fejta-bot · 2019-10-06T20:37:38Z

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

neolit123 · 2019-10-06T20:40:05Z

LGTM
/assign @sttts @mtaufen

Change-Id: I6535b506f50558b31663a13cd270b15023afa2c6

dims · 2019-10-06T22:51:00Z

@klueska we talked about this in the code-organization sub project (sig-arch) and the consensus at least there was that it's worse to force people to import kubernetes/kubernetes than to change things. even when it is in kubernetes/kubernetes, we end up changing stuff anyway and we force people to deal with the breakages. So how will the situation be any different was the thought. One thing better than current situation is that at least they will NOT be forced to import k/k and can use k8s.io/kubelet.

cc @liggitt @smarterclayton

dims · 2019-10-06T22:52:07Z

of course the ultimate arbiter is sig-node here :) cc @derekwaynecarr @dchen1107

dims · 2019-10-06T23:03:36Z

/test pull-kubernetes-kubemark-e2e-gce-big

dims · 2019-10-07T13:43:01Z

@liggitt i debated that as well. both the packages are unusable outside of their current use case of integration with kubelet, and there are 2 of them, so i picked k8s.io/kubelet

liggitt · 2019-10-07T17:28:16Z

both the packages are unusable outside of their current use case of integration with kubelet, and there are 2 of them, so i picked k8s.io/kubelet

if that's the case, that would seem to make sense. will defer to sig-node reviewers

mtaufen · 2019-10-08T03:45:49Z

/assign @dashpole
for an official opinion.

kubelet repo sounds fine IMO

dashpole · 2019-10-08T21:21:58Z

kubelet repo sgtm

dims · 2019-10-09T00:29:47Z

/assign @derekwaynecarr @liggitt

derekwaynecarr · 2019-10-10T17:16:47Z

I am fine with the kubelet repo.

Moving this out of k/k into a more focused repo is the right thing.

/approve
/lgtm

dchen1107 · 2019-10-10T17:34:32Z

/lgtm
/approve

k8s-ci-robot · 2019-10-10T17:34:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, derekwaynecarr, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~hack/OWNERS~~ [dchen1107,dims]
~~pkg/kubelet/OWNERS~~ [dchen1107,derekwaynecarr]
~~staging/src/k8s.io/kubelet/OWNERS~~ [dchen1107]
~~test/images/OWNERS~~ [dchen1107]
~~vendor/OWNERS~~ [dchen1107,dims]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mtaufen · 2019-10-10T18:24:43Z

/lgtm

…belet-apis-to-staging Move external facing kubelet apis to staging

RenaudWasTaken · 2019-10-23T18:53:16Z

Should we move the podresources directory as well? It's pretty tied to device support as it allows to tie device metrics to pods and containers.

Or are we waiting for it to graduate to beta?
cc @dims

As per kubernetes/kubernetes#83551 External facing APIs in plugin registration and device plugin packages are now available under k8s.io/kubelet/pkg/apis/ Signed-off-by: Nikolay Nikolaev <[email protected]>

* Remove the controllers/sriov-controller That is a very outdated code and concept nto relevant anymore. Get rid of it and the whole folder tree to support it. Signed-off-by: Nikolay Nikolaev <[email protected]> * Switch to K8s v1.17.0 Signed-off-by: Nikolay Nikolaev <[email protected]> * In k8s v1.17.0 the kubelet API has moved As per kubernetes/kubernetes#83551 External facing APIs in plugin registration and device plugin packages are now available under k8s.io/kubelet/pkg/apis/ Signed-off-by: Nikolay Nikolaev <[email protected]> * Change the k8s version to v1.17.0 when we int the cluster Packet and Vagrant deplyments wil default to v1.17.0 now. Signed-off-by: Nikolay Nikolaev <[email protected]> * Adapt the tests/fake_client.go to latest API This file is almost an exact copy of https://github.com/kubernetes/client-go/blob/master/rest/fake/fake.go So just import it and adjust names where needed. Signed-off-by: Nikolay Nikolaev <[email protected]> * go mod tidy after a rebase Signed-off-by: Nikolay Nikolaev <[email protected]> * K8s v1.17.1 Signed-off-by: Nikolay Nikolaev <[email protected]> * Cleanups after rebase to master Signed-off-by: Nikolay Nikolaev <[email protected]> * Remove refereces to v0.2.0 Signed-off-by: Nikolay Nikolaev <[email protected]>

dims added 2 commits October 6, 2019 15:28

Move pkg/kubelet/pluginregistration and deviceplugin

d30c489

Change-Id: I06adcb43bd278b430ffad2010869e1524c8cc4ff

update bazel BUILD files

6ecc0f8

Change-Id: Ia3917cec1453c0b22a958faf8c22bccd79242d14

k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 6, 2019

k8s-ci-robot requested review from ixdy and klueska October 6, 2019 19:46

run hack/update-vendor.sh

5d6190c

Change-Id: Ib5a0d3b3e9bd1505a263064f35bea3514c992e4a

k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Oct 6, 2019

k8s-ci-robot assigned mtaufen and sttts Oct 6, 2019

fix gofmt and golint failures

f29d227

Change-Id: I6535b506f50558b31663a13cd270b15023afa2c6

k8s-ci-robot assigned dashpole Oct 8, 2019

k8s-ci-robot assigned derekwaynecarr and liggitt Oct 9, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2019

k8s-ci-robot assigned dchen1107 Oct 10, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2019

k8s-ci-robot merged commit 3db6d3a into kubernetes:master Oct 10, 2019

k8s-ci-robot added this to the v1.17 milestone Oct 10, 2019

ohsewon pushed a commit to ohsewon/kubernetes that referenced this pull request Oct 16, 2019

Merge pull request kubernetes#83551 from dims/move-external-facing-ku…

1e00b1f

…belet-apis-to-staging Move external facing kubelet apis to staging

RenaudWasTaken mentioned this pull request Jun 30, 2020

Move external facing podresources apis to staging #92632

Merged

SergeyKanzhelev mentioned this pull request Jun 30, 2020

Move pkg/kubelet/apis to k8s.io/kubelet/pkg/apis #92527

Closed

TBBle mentioned this pull request Sep 14, 2021

Upgrade to newer Kubernetes version aarnaud/k8s-directx-device-plugin#6

Open

Move external facing kubelet apis to staging #83551

Move external facing kubelet apis to staging #83551

Uh oh!

Conversation

dims commented Oct 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dims commented Oct 6, 2019

Uh oh!

klueska commented Oct 6, 2019

Uh oh!

fejta-bot commented Oct 6, 2019

Uh oh!

neolit123 commented Oct 6, 2019

Uh oh!

dims commented Oct 6, 2019

Uh oh!

dims commented Oct 6, 2019

Uh oh!

dims commented Oct 6, 2019

Uh oh!

dims commented Oct 7, 2019

Uh oh!

liggitt commented Oct 7, 2019

Uh oh!

mtaufen commented Oct 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dashpole commented Oct 8, 2019

Uh oh!

dims commented Oct 9, 2019

Uh oh!

derekwaynecarr commented Oct 10, 2019

Uh oh!

dchen1107 commented Oct 10, 2019

Uh oh!

k8s-ci-robot commented Oct 10, 2019

Uh oh!

mtaufen commented Oct 10, 2019

Uh oh!

RenaudWasTaken commented Oct 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

dims commented Oct 6, 2019 •

edited

Loading

mtaufen commented Oct 8, 2019 •

edited

Loading

RenaudWasTaken commented Oct 23, 2019 •

edited

Loading